terrymanu commented on a change in pull request #3169: improved coverage for pagination package in sharding-core-preprocessor module URL: https://github.com/apache/incubator-shardingsphere/pull/3169#discussion_r332338026
########## File path: sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/optimize/segment/select/pagination/engine/TopPaginationContextEngineTest.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.core.optimize.segment.select.pagination.engine; + +import com.google.common.base.Optional; +import org.apache.shardingsphere.core.optimize.segment.select.pagination.PaginationContext; +import org.apache.shardingsphere.core.optimize.segment.select.projection.ProjectionsContext; +import org.apache.shardingsphere.core.parse.sql.segment.dml.column.ColumnSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.expr.simple.LiteralExpressionSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.pagination.PaginationValueSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.pagination.rownum.NumberLiteralRowNumberValueSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.pagination.top.TopSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.predicate.AndPredicate; +import org.apache.shardingsphere.core.parse.sql.segment.dml.predicate.PredicateSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.predicate.value.PredicateCompareRightValue; +import org.junit.Before; +import org.junit.Test; + +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; +import static org.junit.Assert.assertTrue; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public final class TopPaginationContextEngineTest { + private TopPaginationContextEngine topPaginationContextEngine; + + @Before + public void setUp() { + topPaginationContextEngine = new TopPaginationContextEngine(); + } + + @Test + public void assertCreatePaginationContextWhenRowNumberPredicateNotPresent() { + TopSegment topSegment = new TopSegment(0, 10, "text", null, "rowNumberAlias"); + Collection<AndPredicate> andPredicates = Collections.emptyList(); + List<Object> parameters = Collections.emptyList(); + PaginationContext paginationContext = topPaginationContextEngine.createPaginationContext(topSegment, andPredicates, parameters); + assertThat(paginationContext.getOffsetSegment(), is(Optional.<PaginationValueSegment>absent())); + assertThat(paginationContext.getRowCountSegment(), is(Optional.<PaginationValueSegment>absent())); + } + + @Test + public void assertCreatePaginationContextWhenRowNumberPredicatePresentAndOperatorIsGreatThan() { + String name = "rowNumberAlias"; + ColumnSegment columnSegment = new ColumnSegment(0, 10, name); + PredicateCompareRightValue predicateCompareRightValue = mock(PredicateCompareRightValue.class); + when(predicateCompareRightValue.getOperator()).thenReturn(">"); + when(predicateCompareRightValue.getExpression()).thenReturn(new LiteralExpressionSegment(0, 10, 100)); + PredicateSegment predicateSegment = new PredicateSegment(0, 10, columnSegment, predicateCompareRightValue); + AndPredicate andPredicate = new AndPredicate(); + andPredicate.getPredicates().add(predicateSegment); + Collection<AndPredicate> andPredicates = Collections.singleton(andPredicate); + ProjectionsContext projectionsContext = mock(ProjectionsContext.class); + String rowNumberAlias = "predicateRowNumberAlias"; + when(projectionsContext.findAlias(anyString())).thenReturn(Optional.of(rowNumberAlias)); + List<Object> parameters = Collections.emptyList(); + TopSegment topSegment = new TopSegment(0, 10, "text", null, name); + PaginationContext paginationContext = topPaginationContextEngine.createPaginationContext(topSegment, andPredicates, parameters); + Optional<PaginationValueSegment> paginationValueSegmentOptional = paginationContext.getOffsetSegment(); + assertTrue(paginationValueSegmentOptional.isPresent()); + PaginationValueSegment paginationValueSegment = paginationValueSegmentOptional.get(); + assertTrue(paginationValueSegment instanceof NumberLiteralRowNumberValueSegment); + NumberLiteralRowNumberValueSegment numberLiteralRowNumberValueSegment = (NumberLiteralRowNumberValueSegment) paginationValueSegment; + assertThat(numberLiteralRowNumberValueSegment.getStartIndex(), is(0)); + assertThat(numberLiteralRowNumberValueSegment.getStopIndex(), is(10)); + assertThat(numberLiteralRowNumberValueSegment.getValue(), is(100L)); + assertThat(paginationContext.getRowCountSegment(), is(Optional.<PaginationValueSegment>absent())); Review comment: Can use `assertFalse(paginationContext.getRowCountSegment().isPresent())` to instead of binary assertion. Using unary assertion for high priority if it passable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
