terrymanu commented on a change in pull request #3205: bugfix for #3144
URL:
https://github.com/apache/incubator-shardingsphere/pull/3205#discussion_r333381164
##########
File path:
sharding-core/sharding-core-route/src/test/java/org/apache/shardingsphere/core/route/router/sharding/validator/impl/ShardingInsertStatementValidatorTest.java
##########
@@ -41,13 +43,13 @@
@Test
public void assertValidateOnDuplicateKeyWithoutShardingKey() {
when(shardingRule.isShardingColumn("id", "user")).thenReturn(false);
- new ShardingInsertStatementValidator().validate(shardingRule,
createInsertStatement());
+ new ShardingInsertStatementValidator().validate(shardingRule,
createInsertStatement(), Lists.newArrayList());
Review comment:
Using `Collections.emptyList()` instead of `Lists.newArrayList()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
