terrymanu commented on a change in pull request #3251: fix #3213
URL:
https://github.com/apache/incubator-shardingsphere/pull/3251#discussion_r334441882
##########
File path:
sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/DerivedColumnTest.java
##########
@@ -27,28 +27,20 @@
public final class DerivedColumnTest {
@Test
- public void assertGetDerivedColumnAlias() {
+ public void assertGetDerivedColumnNameAlias() {
assertThat(DerivedColumn.AVG_COUNT_ALIAS.getDerivedColumnAlias(0),
is("AVG_DERIVED_COUNT_0"));
assertThat(DerivedColumn.AVG_SUM_ALIAS.getDerivedColumnAlias(1),
is("AVG_DERIVED_SUM_1"));
assertThat(DerivedColumn.ORDER_BY_ALIAS.getDerivedColumnAlias(0),
is("ORDER_BY_DERIVED_0"));
assertThat(DerivedColumn.GROUP_BY_ALIAS.getDerivedColumnAlias(1),
is("GROUP_BY_DERIVED_1"));
}
-
- @Test
- public void assertIsDerivedColumn() {
- assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_COUNT_0"));
- assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_SUM_1"));
- assertTrue(DerivedColumn.isDerivedColumn("ORDER_BY_DERIVED_0"));
- assertTrue(DerivedColumn.isDerivedColumn("GROUP_BY_DERIVED_1"));
- }
-
- @Test
- public void assertIsNotDerivedColumn() {
- assertFalse(DerivedColumn.isDerivedColumn("OTHER_DERIVED_COLUMN_0"));
- }
-
+
@Test
public void assertIsDerivedColumnName() {
+ assertTrue(DerivedColumn.isDerivedColumnName("AVG_DERIVED_COUNT_0"));
Review comment:
Line 39 and line 44 are same test case, please remove one of it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
