terrymanu commented on a change in pull request #3260: Delete duplicate method:
isDerivedColumnName
URL:
https://github.com/apache/incubator-shardingsphere/pull/3260#discussion_r334443600
##########
File path:
sharding-core/sharding-core-preprocessor/src/main/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/DerivedColumn.java
##########
@@ -49,22 +49,7 @@
public String getDerivedColumnAlias(final int derivedColumnCount) {
return String.format(pattern + "%s", derivedColumnCount);
}
-
- /**
- * Judge is derived column name or not.
- *
- * @param columnName column name to be judged
- * @return is derived column name or not
- */
- public static boolean isDerivedColumnName(final String columnName) {
- for (DerivedColumn each : DerivedColumn.values()) {
- if (columnName.startsWith(each.pattern)) {
- return true;
- }
- }
- return false;
- }
-
+
Review comment:
Please do not change original indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
