terrymanu commented on a change in pull request #3254: purge duplicate method :
isDerivedColumnName
URL:
https://github.com/apache/incubator-shardingsphere/pull/3254#discussion_r334456025
##########
File path:
sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/DerivedColumnTest.java
##########
@@ -36,28 +36,15 @@ public void assertGetDerivedColumnAlias() {
@Test
public void assertIsDerivedColumn() {
- assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_COUNT_0"));
- assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_SUM_1"));
- assertTrue(DerivedColumn.isDerivedColumn("ORDER_BY_DERIVED_0"));
- assertTrue(DerivedColumn.isDerivedColumn("GROUP_BY_DERIVED_1"));
+ assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_COUNT_"));
+ assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_SUM_"));
+ assertTrue(DerivedColumn.isDerivedColumn("ORDER_BY_DERIVED_"));
+ assertTrue(DerivedColumn.isDerivedColumn("GROUP_BY_DERIVED_"));
+
assertFalse(DerivedColumn.isDerivedColumn("AGGREGATION_DISTINCT_DERIVED_"));
Review comment:
`assertIsNotDerivedColumn`, should not in `assertIsDerivedColumn` method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
