terrymanu commented on issue #3263: Delete duplicate method: isDerivedColumnName URL: https://github.com/apache/incubator-shardingsphere/pull/3263#issuecomment-542015370 I just carry on the comment from #3213 I check the code carefully, they are different with that 2 methods. In method `isDerivedColumnName`, it use `DerivedColumn.values()`; In method `isDerivedColumn`, it use `DerivedColumn.getValues()`; The different of `DerivedColumn.values()` and `DerivedColumn.getValues()` is deal with AGGREGATION_DISTINCT_DERIVED. So we cannot just merge those 2 methods, need refactor further. So I just close this pr, please keep focus is you want to continue refactor this method, thank you.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
