gufengwyx8 edited a comment on issue #3276: Add table owner for logic encrypt 
column
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542070737
 
 
   > @gufengwyx8 Hi, So great and so fast!
   > The solution in your PR is correct, but to make the members of 
`EncryptCondition` and `EncryptPredicateToken` less, can you keep 
`ColumnSegment` in `EncryptPredicateToken` and delete `columnName`? Through 
that, we can get `columnName` and `its owner` from `ColumnSegment` in 
`ColumnSegment`.
   
   I can't reduce the member ```columnName``` in ```EncryptPredicateToken ``` 
because this name has been converted by ```EncryptPredicateTokenGenerator#87``` 
and ```EncryptPredicateTokenGenerator#101```, this name cannot be proved with 
`ColumnSegment`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to