tristaZero commented on a change in pull request #3276: Add table owner for
logic encrypt column
URL:
https://github.com/apache/incubator-shardingsphere/pull/3276#discussion_r334892991
##########
File path:
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/column/ColumnSegment.java
##########
@@ -65,6 +65,15 @@ public ColumnSegment(final int startIndex, final int
stopIndex, final String nam
public final String getQualifiedName() {
return null == owner ? name : owner.getTableName() + "." + name;
}
+
+ /**
+ * Get owner name.
+ *
+ * @return owner name
+ */
+ public final String getOwnerName() {
+ return null == owner ? null : owner.getTableName();
+ }
@Override
public final Optional<TableSegment> getOwner() {
Review comment:
Instead of adding a new function `getOwnerName()`, why don't we use
getOwner()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
