terrymanu commented on a change in pull request #3281: #3138 improved coverage
for sharding core preprocessor
URL:
https://github.com/apache/incubator-shardingsphere/pull/3281#discussion_r335034008
##########
File path:
sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/engine/ProjectionsContextEngineTest.java
##########
@@ -59,4 +62,40 @@ public void
assertProjectionsContextCreatedProperlyWhenSelectItemPresent() {
ProjectionsContext projectionsContext = new
ProjectionsContextEngine(null).createProjectionsContext(null, selectStatement,
mock(GroupByContext.class), mock(OrderByContext.class));
assertNotNull(projectionsContext);
}
+
+ @Test
+ public void
assertProjectionsContextCreatedProperlyWhenOrderByContextOrderItemsPresent() {
Review comment:
The test method name should same with to be tested method name, so the
better name should be `assert
createProjectionsContextWhenOrderByContextOrderItemsPresent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
