KomachiSion commented on a change in pull request #3288: fixes
QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
URL:
https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335335594
##########
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultUtil.java
##########
@@ -105,9 +105,9 @@ private static Object getValueByColumnType(final ResultSet
resultSet, final int
case Types.TINYINT:
case Types.SMALLINT:
case Types.INTEGER:
- return resultSet.getInt(columnIndex);
+ return getIntTypeValue(resultSet, columnIndex);
Review comment:
TINYINT and SAMLLINT use getInt is enough
INTEGER if isSigned, should still getInt, if isUnsigned can getLong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
