terrymanu commented on a change in pull request #3295: fixed for #3234 and add
the encrypted test case for more than four cipher coloumns
URL:
https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335554538
##########
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptAssignmentParameterRewriter.java
##########
@@ -78,22 +81,24 @@ private SetAssignmentsSegment
getSetAssignmentsSegment(final SQLStatement sqlSta
return ((UpdateStatement) sqlStatement).getSetAssignment();
}
- private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List<Object> parameters) {
+ private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List<Object> parameters,
+ final Collection<String>
assistedQueryColumns, final int count) {
Review comment:
What is the proposal of parameter `count`?
I just try to understander is that the `count` means count of `Assignment`
(`xxx = ?`).
How about if one `Assignment` have multiple parameters, such as `xxx = ? + ?`
Or the `Assignment` do not has any parameters, such as `xxx = 100`
Any suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
