Pramy commented on a change in pull request #3344: postgres execute bind
parameter ERROR paser
URL:
https://github.com/apache/incubator-shardingsphere/pull/3344#discussion_r337878886
##########
File path:
sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLStringBinaryProtocolValue.java
##########
@@ -33,7 +33,10 @@ public int getColumnLength(final Object value) {
@Override
public Object read(final PostgreSQLPacketPayload payload) {
- return payload.readStringNul();
+ payload.getByteBuf().readerIndex(payload.getByteBuf().readerIndex() -
4);
Review comment:
Will it affect other `PostgreSQLBinaryProtocolValue` if remove
payload.readInt4() in getParameters()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
