tuohai666 commented on a change in pull request #3347: PostgreSQL parse create
table statement keyword datatype
URL:
https://github.com/apache/incubator-shardingsphere/pull/3347#discussion_r337949530
##########
File path:
sharding-core/sharding-core-parse/sharding-core-parse-mysql/src/main/antlr4/imports/mysql/BaseRule.g4
##########
@@ -107,8 +107,7 @@ unreservedWord_
| IMPORT | CONCURRENT | XML | POSITION | SHARE | DUMPFILE | CLONE |
AGGREGATE | INSTALL | UNINSTALL
| RESOURCE | FLUSH | RESET | RESTART | HOSTS | RELAY | EXPORT |
USER_RESOURCES | SLOW | GENERAL | CACHE
| SUBJECT | ISSUER | OLD | RANDOM | RETAIN | MAX_USER_CONNECTIONS |
MAX_CONNECTIONS_PER_HOUR | MAX_UPDATES_PER_HOUR
- | MAX_QUERIES_PER_HOUR | REUSE | OPTIONAL | HISTORY | NEVER | EXPIRE
-
+ | MAX_QUERIES_PER_HOUR | REUSE | OPTIONAL | HISTORY | NEVER | EXPIRE |
UNIX_TIMESTAMP | LOWER
Review comment:
need to add 'type' according to
https://dev.mysql.com/doc/refman/5.7/en/keywords.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
