sandynz opened a new issue, #20128: URL: https://github.com/apache/shardingsphere/issues/20128
Purpose - Separate InventoryDumper from ScalingEntry for better reuse Possible changes: - Add InventoryDumperCreator interface, extends TypedSPI, marked as @SingletonSPI; Put in the same module and package of AbstractInventoryDumper; - Add MySQL & PostgreSQL & Fixture implementations of InventoryDumperCreator; Register them in resources/WEB-INF.services - Add InventoryDumperCreatorFactory; Put in the same module and package of AbstractInventoryDumper; - Add InventoryDumperCreatorFactoryTest in shardingsphere-pipeline-test module, assert get instance of InventoryDumperCreator by type "MySQL" / "PostgreSQL" / "Fixture"; - Remove ScalingEntry.getInventoryDumperClass() method - Remove DumperFactory.createInventoryDumper method and update related code - Update related unit test Example: - ImporterCreator, ImporterCreatorFactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
