This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 88e94c86ac7 Refactor : make the constant class a NoArgsConstructor
(#20177)
88e94c86ac7 is described below
commit 88e94c86ac78c9956543c08410d735ec4d49160a
Author: 孙念君 Nianjun Sun <[email protected]>
AuthorDate: Mon Aug 15 12:03:43 2022 +0800
Refactor : make the constant class a NoArgsConstructor (#20177)
* Refactor : make the constant class a NoArgsConstructor
* Format : format the transaction it code
* Refactor : refactor the transaction related class
---
.../integration/transaction/engine/command/CommonSQLCommand.java | 1 -
.../transaction/engine/constants/TransactionTestConstants.java | 5 ++++-
.../transaction/engine/mysql/MySQLJdbcTransactionIT.java | 1 -
.../transaction/engine/mysql/MySQLProxyTransactionIT.java | 1 -
.../transaction/engine/opengauss/OpenGaussJdbcTransactionIT.java | 1 -
.../transaction/engine/opengauss/OpenGaussProxyTransactionIT.java | 1 -
.../transaction/engine/postgresql/PostgreSQLJdbcTransactionIT.java | 1 -
.../transaction/engine/postgresql/PostgreSQLProxyTransactionIT.java | 1 -
.../framework/container/compose/DockerComposedContainer.java | 1 -
.../transaction/framework/param/TransactionParameterized.java | 2 +-
.../transaction/util/TransactionTestCaseClassScanner.java | 6 ++++--
11 files changed, 9 insertions(+), 12 deletions(-)
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/command/CommonSQLCommand.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/command/CommonSQLCommand.java
index a516bd5574a..1a7923a31e8 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/command/CommonSQLCommand.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/command/CommonSQLCommand.java
@@ -79,5 +79,4 @@ public final class CommonSQLCommand {
@XmlElement(name = "create-order-item-table")
private String createOrderItemTable;
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/constants/TransactionTestConstants.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/constants/TransactionTestConstants.java
index 2bc640dab7c..769069cd2d4 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/constants/TransactionTestConstants.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/constants/TransactionTestConstants.java
@@ -17,9 +17,13 @@
package org.apache.shardingsphere.integration.transaction.engine.constants;
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+
/**
* Constants for transaction test.
*/
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class TransactionTestConstants {
public static final String MYSQL = "mysql";
@@ -43,5 +47,4 @@ public final class TransactionTestConstants {
public static final String NARAYANA = "Narayana";
public static final String BITRONIX = "Bitronix";
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLJdbcTransactionIT.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLJdbcTransactionIT.java
index 93fa2b63d83..a4d5cd06d8b 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLJdbcTransactionIT.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLJdbcTransactionIT.java
@@ -62,5 +62,4 @@ public final class MySQLJdbcTransactionIT extends
BaseTransactionITCase {
public void assertTransaction() {
callTestCases(parameterized);
}
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLProxyTransactionIT.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLProxyTransactionIT.java
index b20b71c72ee..9798eae7bf6 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLProxyTransactionIT.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/mysql/MySQLProxyTransactionIT.java
@@ -78,5 +78,4 @@ public final class MySQLProxyTransactionIT extends
BaseTransactionITCase {
public void assertTransaction() {
callTestCases(parameterized);
}
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussJdbcTransactionIT.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussJdbcTransactionIT.java
index 4d442403597..4bcdc0c49f0 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussJdbcTransactionIT.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussJdbcTransactionIT.java
@@ -67,5 +67,4 @@ public final class OpenGaussJdbcTransactionIT extends
BaseTransactionITCase {
private void callTestCases() {
callTestCases(parameterized);
}
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussProxyTransactionIT.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussProxyTransactionIT.java
index a2057a43d88..9938758181a 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussProxyTransactionIT.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/opengauss/OpenGaussProxyTransactionIT.java
@@ -83,5 +83,4 @@ public final class OpenGaussProxyTransactionIT extends
BaseTransactionITCase {
private void callTestCases() {
callTestCases(parameterized);
}
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLJdbcTransactionIT.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLJdbcTransactionIT.java
index 74d12157b41..d7077215932 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLJdbcTransactionIT.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLJdbcTransactionIT.java
@@ -67,5 +67,4 @@ public final class PostgreSQLJdbcTransactionIT extends
BaseTransactionITCase {
private void callTestCases() {
callTestCases(parameterized);
}
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLProxyTransactionIT.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLProxyTransactionIT.java
index 16c065f8f53..386bf49deb1 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLProxyTransactionIT.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/engine/postgresql/PostgreSQLProxyTransactionIT.java
@@ -83,5 +83,4 @@ public final class PostgreSQLProxyTransactionIT extends
BaseTransactionITCase {
private void callTestCases() {
callTestCases(parameterized);
}
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/container/compose/DockerComposedContainer.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/container/compose/DockerComposedContainer.java
index ad18a848d61..555343f96db 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/container/compose/DockerComposedContainer.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/container/compose/DockerComposedContainer.java
@@ -97,5 +97,4 @@ public final class DockerComposedContainer extends
BaseComposedContainer {
public String getProxyJdbcUrl(final String databaseName) {
return DataSourceEnvironment.getURL(databaseType,
proxyContainer.getHost(), proxyContainer.getFirstMappedPort(), databaseName);
}
-
}
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/param/TransactionParameterized.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/param/TransactionParameterized.java
index a1a06d9410d..af22a613aa7 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/param/TransactionParameterized.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/framework/param/TransactionParameterized.java
@@ -28,8 +28,8 @@ import java.util.Collection;
/**
* Transaction test parameters.
*/
-@Getter
@RequiredArgsConstructor
+@Getter
public final class TransactionParameterized {
private final DatabaseType databaseType;
diff --git
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/util/TransactionTestCaseClassScanner.java
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/util/TransactionTestCaseClassScanner.java
index 45cf8c80790..387c89bb7ff 100644
---
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/util/TransactionTestCaseClassScanner.java
+++
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/util/TransactionTestCaseClassScanner.java
@@ -17,6 +17,8 @@
package org.apache.shardingsphere.integration.transaction.util;
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
import lombok.SneakyThrows;
import
org.apache.shardingsphere.integration.transaction.cases.base.BaseTransactionTestCase;
@@ -37,7 +39,8 @@ import java.util.jar.JarFile;
/**
* Scan the transaction test classes to be tested.
*/
-public class TransactionTestCaseClassScanner {
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class TransactionTestCaseClassScanner {
private static final String TEST_CASE_PACKAGE_NAME =
"org.apache.shardingsphere.integration.transaction.cases";
@@ -130,5 +133,4 @@ public class TransactionTestCaseClassScanner {
}
}
}
-
}
