sunkai-cai opened a new pull request, #20206:
URL: https://github.com/apache/shardingsphere/pull/20206
Fixes #20032.
Changes proposed in this pull request:
- Add parser test cases in module `shardingsphere-db-discovery-distsql`
- Refactor parameter definition of DatabaseDiscoveryDistSQL
1. CREATE DB_DISCOVERY RULE
before:
```
CREATE DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1),
TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
after
```
CREATE DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1),
TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
3. ALTER DB_DISCOVERY RULE
before:
```
ALTER DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1),
TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
after:
```
ALTER DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1),
TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
5. CREATE DB_DISCOVERY TYPE
before:
```
CREATE DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME=mgr));
```
after:
```
CREATE DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME='mgr'));
```
7. ALTER DB_DISCOVERY TYPE
before:
```
ALTER DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME=mgr));
```
after:
```
ALTER DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME='mgr'));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]