sandynz commented on code in PR #20244:
URL: https://github.com/apache/shardingsphere/pull/20244#discussion_r947850046
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/test/java/org/apache/shardingsphere/data/pipeline/core/fixture/MigrationJobAPIFixture.java:
##########
@@ -146,6 +148,11 @@ public MigrationJobConfiguration getJobConfiguration(final
String jobId) {
return null;
}
+ @Override
+ public TaskConfiguration buildTaskConfiguration(final
MigrationJobConfiguration jobConfig, final int jobShardingItem, final
PipelineProcessConfiguration pipelineProcessConfig) {
+ return null;
Review Comment:
It's in traditional Fixture code, this method won't be invoked.
And this class might be removed later, it doesn't benefit for real running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
