boyjoy1127 commented on code in PR #20186:
URL: https://github.com/apache/shardingsphere/pull/20186#discussion_r949099496
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/FederationExecutorFactory.java:
##########
@@ -34,20 +34,20 @@ public final class FederationExecutorFactory {
/**
* Create new instance of federation executor factory.
- *
- * @param databaseName database name
- * @param schemaName schema name
+ *
+ * @param databaseName database name
+ * @param schemaName schema name
* @param globalRuleMetaData global rule meta data
- * @param optimizerContext filterable optimizer context
- * @param props configuration properties
- * @param jdbcExecutor jdbc executor
- * @param eventBusContext event bus context
+ * @param optimizerContext filterable optimizer context
+ * @param props configuration properties
+ * @param jdbcExecutor jdbc executor
+ * @param eventBusContext event bus context
* @return created instance
*/
public static FederationExecutor newInstance(final String databaseName,
final String schemaName, final OptimizerContext optimizerContext,
final
ShardingSphereRuleMetaData globalRuleMetaData, final ConfigurationProperties
props, final JDBCExecutor jdbcExecutor,
final EventBusContext
eventBusContext) {
- // TODO Consider about AdvancedFederationExecutor
+ // TODO Consider about AdvancedFederationExecutor and
TranslatableFederationExecutor
Review Comment:
No, we can't. They use different type of schema and table.
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/FederationExecutorFactory.java:
##########
@@ -34,20 +34,20 @@ public final class FederationExecutorFactory {
/**
* Create new instance of federation executor factory.
- *
- * @param databaseName database name
- * @param schemaName schema name
+ *
+ * @param databaseName database name
+ * @param schemaName schema name
* @param globalRuleMetaData global rule meta data
- * @param optimizerContext filterable optimizer context
- * @param props configuration properties
- * @param jdbcExecutor jdbc executor
- * @param eventBusContext event bus context
+ * @param optimizerContext filterable optimizer context
+ * @param props configuration properties
+ * @param jdbcExecutor jdbc executor
+ * @param eventBusContext event bus context
* @return created instance
*/
public static FederationExecutor newInstance(final String databaseName,
final String schemaName, final OptimizerContext optimizerContext,
final
ShardingSphereRuleMetaData globalRuleMetaData, final ConfigurationProperties
props, final JDBCExecutor jdbcExecutor,
final EventBusContext
eventBusContext) {
- // TODO Consider about AdvancedFederationExecutor
+ // TODO Consider about AdvancedFederationExecutor and
TranslatableFederationExecutor
Review Comment:
No, we can't. They use different type of schema and table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
