sandynz opened a new issue, #20334: URL: https://github.com/apache/shardingsphere/issues/20334
Purpose - Separate IncrementalDumper from ScalingEntry for better reuse Possible changes: - Add IncrementalDumperCreator interface, extends TypedSPI, marked as @SingletonSPI; Put in the same module and package of AbstractIncrementalDumper; - Add MySQL & PostgreSQL & openGauss & Fixture implementations of IncrementalDumperCreator; Register them in resources/WEB-INF.services - Add IncrementalDumperCreatorFactory; Put in the same module and package of AbstractIncrementalDumper; - Add IncrementalDumperCreatorFactoryTest in shardingsphere-pipeline-test module, assert get instance of IncrementalDumperCreator by type "MySQL" / "PostgreSQL" / "openGauss" / "Fixture"; - Remove ScalingEntry.getIncrementalDumperClass() method - Remove DumperFactory.createIncrementalDumper method and update related code - Update related unit test - Keep ScalingEntry and related classes & configs for now Example: - InventoryDumperCreator, InventoryDumperCreatorFactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
