sandynz commented on code in PR #20468:
URL: https://github.com/apache/shardingsphere/pull/20468#discussion_r952513309
##########
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-api/src/main/java/org/apache/shardingsphere/encrypt/api/config/EncryptRuleConfiguration.java:
##########
@@ -44,13 +42,11 @@ public final class EncryptRuleConfiguration implements
DatabaseRuleConfiguration
private final String dataConverterName;
Review Comment:
`dataConverterName` could be removed
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/rdl/rdl-integration-test-cases.xml:
##########
@@ -93,10 +93,8 @@
<!-- <assertion expected-data-file="alter_binding_rules.xml">-->
<!-- <initial-sql sql="CREATE SHARDING TABLE RULE t_user (-->
<!-- RESOURCES("encrypt_write_ds_${0..9}"),-->
-<!-- SHARDING_COLUMN=user_id, TYPE(NAME=MOD,
PROPERTIES("sharding-count"=40)))));-->
-<!-- CREATE SHARDING SCALING RULE default_scaling;-->
-<!-- ALTER SHARDING BINDING TABLE RULES
(t_user,t_user_item);"/>-->
-<!-- <destroy-sql sql="DROP SHARDING BINDING TABLE RULES;DROP
SHARDING TABLE RULE t_user;DROP SHARDING SCALING RULE default_scaling" />-->
+<!-- SHARDING_COLUMN=user_id, TYPE(NAME=MOD,
PROPERTIES("sharding-count"=40)))));"/>-->
+<!-- <destroy-sql sql="DROP SHARDING BINDING TABLE RULES;DROP
SHARDING TABLE RULE t_user" />-->
Review Comment:
Maybe `ALTER SHARDING BINDING TABLE RULES (t_user,t_user_item);` is still
needed
##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-parser/src/main/antlr4/imports/migration/RDLStatement.g4:
##########
@@ -18,71 +18,3 @@
grammar RDLStatement;
Review Comment:
RDLStatement.g4 could be removed
##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-parser/src/main/java/org/apache/shardingsphere/migration/distsql/parser/core/MigrationDistSQLStatementVisitor.java:
##########
@@ -342,9 +207,4 @@ public ASTNode visitAddMigrationSourceResource(final
AddMigrationSourceResourceC
public ASTNode visitDropMigrationSourceResource(final
DropMigrationSourceResourceContext ctx) {
return new
DropMigrationSourceResourceStatement(ctx.resourceName().stream().map(ParseTree::getText).map(each
-> new IdentifierValue(each).getValue()).collect(Collectors.toList()));
}
-
- @Override
- public ASTNode visitShowMigrationSourceResources(final
ShowMigrationSourceResourcesContext ctx) {
- return new ShowMigrationSourceResourcesStatement();
- }
Review Comment:
Is `visitShowMigrationSourceResources` not needed any more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
