sandynz commented on code in PR #20480:
URL: https://github.com/apache/shardingsphere/pull/20480#discussion_r953363055
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/job/FinishedCheckJob.java:
##########
@@ -73,20 +73,13 @@ public void execute(final ShardingContext shardingContext) {
continue;
}
Review Comment:
FinishedCheckJob could be removed, and also FinishedCheckJobExecutor
##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/DistSQLBackendHandlerFactoryTest.java:
##########
@@ -31,6 +31,7 @@
import
org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
import
org.apache.shardingsphere.infra.metadata.database.resource.ShardingSphereResource;
import
org.apache.shardingsphere.infra.metadata.database.rule.ShardingSphereRuleMetaData;
+import
org.apache.shardingsphere.migration.distsql.statement.ShowMigrationCheckAlgorithmsStatement;
Review Comment:
Unit test of ShowMigrationCheckAlgorithmsStatement could be removed too,
this unit test is cross module and it's error prone. It could be put to DistSQL
integration test later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
