cowboysync commented on code in PR #20255:
URL: https://github.com/apache/shardingsphere/pull/20255#discussion_r956527352
##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/algorithm/sharding/datetime/IntervalShardingAlgorithmTest.java:
##########
@@ -448,4 +448,12 @@ public void assertIntegerInJDBCType() {
new RangeShardingValue<>("t_order", "create_time",
DATA_NODE_INFO, Range.closed("04", "10")));
assertThat(actualAsMonthString.size(), is(4));
}
+
+ @Test
+ public void assertDateInSqlDate() {
+ Collection<String> actualAsLocalDate =
shardingAlgorithmByJDBCDate.doSharding(availableTablesForJDBCDateDataSources,
+ new RangeShardingValue<>("t_order", "create_time",
DATA_NODE_INFO,
+ Range.closed(new Date(2021 - 1900, 6 - 1, 15), new
Date(2021 - 1900, 7 - 1, 31))));
Review Comment:
change to use the Java 8 Date Time API to construct java.sql.Date instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
