This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 6846b2cd823 Support Parsing ALTER TRIGGER in PostgreSQL (#20611)
6846b2cd823 is described below
commit 6846b2cd82389d7ac18f36d030d31082e900f991
Author: Everly Precia Suresh <[email protected]>
AuthorDate: Sun Aug 28 12:11:45 2022 +0530
Support Parsing ALTER TRIGGER in PostgreSQL (#20611)
---
.../parser/autogen/PostgreSQLStatementParser.g4 | 1 +
.../impl/PostgreSQLDDLStatementSQLVisitor.java | 7 ++++++
.../ddl/PostgreSQLAlterTriggerStatement.java | 29 ++++++++++++++++++++++
.../src/main/resources/case/ddl/alter-trigger.xml | 2 ++
.../resources/sql/supported/ddl/alter-trigger.xml | 2 ++
.../main/resources/sql/unsupported/unsupported.xml | 2 --
6 files changed, 41 insertions(+), 2 deletions(-)
diff --git
a/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.g4
b/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.g4
index 8723590f50c..c0c0a7acd24 100644
---
a/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.g4
+++
b/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.g4
@@ -177,5 +177,6 @@ execute
| createOperator
| alterTextSearchConfiguration
| createPolicy
+ | alterTrigger
) SEMI_? EOF
;
diff --git
a/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/impl/PostgreSQLDDLStatementSQLVisitor.java
b/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/impl/PostgreSQLDDLStatementSQLVisitor.java
index a9d62061c79..8db79e3f042 100644
---
a/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/impl/PostgreSQLDDLStatementSQLVisitor.java
+++
b/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/impl/PostgreSQLDDLStatementSQLVisitor.java
@@ -51,6 +51,7 @@ import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.Al
import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.AlterServerContext;
import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.AlterStatisticsContext;
import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.AlterSubscriptionContext;
+import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.AlterTriggerContext;
import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.AlterTableActionContext;
import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.AlterTableContext;
import
org.apache.shardingsphere.sql.parser.autogen.PostgreSQLStatementParser.AlterTablespaceContext;
@@ -227,6 +228,7 @@ import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterServerStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterStatisticsStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterSubscriptionStatement;
+import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterTriggerStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterTableStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterTablespaceStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterTextSearchStatement;
@@ -509,6 +511,11 @@ public final class PostgreSQLDDLStatementSQLVisitor
extends PostgreSQLStatementS
return new PostgreSQLAlterSubscriptionStatement();
}
+ @Override
+ public ASTNode visitAlterTrigger(final AlterTriggerContext ctx) {
+ return new PostgreSQLAlterTriggerStatement();
+ }
+
@Override
public ASTNode visitRenameTableSpecification(final
RenameTableSpecificationContext ctx) {
RenameTableDefinitionSegment result = new
RenameTableDefinitionSegment(ctx.start.getStartIndex(),
ctx.stop.getStopIndex());
diff --git
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/postgresql/ddl/PostgreSQLAlterTriggerStatement.java
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/postgresql/ddl/PostgreSQLAlterTriggerStatement.java
new file mode 100644
index 00000000000..1a2649b88ca
--- /dev/null
+++
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/postgresql/ddl/PostgreSQLAlterTriggerStatement.java
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl;
+
+import lombok.ToString;
+import
org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.AlterTriggerStatement;
+import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.PostgreSQLStatement;
+
+/**
+ * PostgreSQL alter trigger statement.
+ */
+@ToString(callSuper = true)
+public final class PostgreSQLAlterTriggerStatement extends
AlterTriggerStatement implements PostgreSQLStatement {
+}
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ddl/alter-trigger.xml
b/shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ddl/alter-trigger.xml
index 074d19faa13..2e724fdf27f 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ddl/alter-trigger.xml
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ddl/alter-trigger.xml
@@ -18,6 +18,8 @@
<sql-parser-test-cases>
<alter-trigger sql-case-id="alter_trigger" />
+ <alter-trigger sql-case-id="alter_trigger_rename" />
+ <alter-trigger sql-case-id="alter_trigger_extension" />
<alter-trigger sql-case-id="alter_trigger_disable" />
<alter-trigger sql-case-id="alter_trigger_enable" />
</sql-parser-test-cases>
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ddl/alter-trigger.xml
b/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ddl/alter-trigger.xml
index 852c95c7af4..caae40b134f 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ddl/alter-trigger.xml
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ddl/alter-trigger.xml
@@ -21,6 +21,8 @@
ON Sales.SalesPersonQuotaHistory
AFTER INSERT
AS INSERT INTO SalesPersonQuotaHistory VALUES(t1, 100)"
db-types="SQLServer" />
+ <sql-case id="alter_trigger_rename" value="ALTER TRIGGER emp_stamp ON emp
RENAME TO emp_track_chgs;" db-types="PostgreSQL" />
+ <sql-case id="alter_trigger_extension" value="ALTER TRIGGER emp_stamp ON
emp DEPENDS ON EXTENSION emplib;" db-types="PostgreSQL" />
<sql-case id="alter_trigger_disable" value="ALTER TRIGGER
update_job_history DISABLE;" db-types="Oracle" />
<sql-case id="alter_trigger_enable" value="ALTER TRIGGER
update_job_history ENABLE;" db-types="Oracle" />
</sql-cases>
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/unsupported/unsupported.xml
b/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/unsupported/unsupported.xml
index 28dff86fbbe..e454a361744 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/unsupported/unsupported.xml
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/unsupported/unsupported.xml
@@ -3284,7 +3284,6 @@
<sql-case id="alter_by_postgresql_source_test_case387" value="ALTER TABLE
reloptions_test RESET (toast.autovacuum_vacuum_cost_delay);"
db-types="PostgreSQL" />
<sql-case id="alter_by_postgresql_source_test_case388" value="ALTER TABLE
reloptions_test SET (autovacuum_enabled, fillfactor=32);" db-types="PostgreSQL"
/>
<sql-case id="alter_by_postgresql_source_test_case389" value="ALTER TABLE
reloptions_test SET (toast.autovacuum_vacuum_cost_delay = 24);"
db-types="PostgreSQL" />
- <sql-case id="alter_by_postgresql_source_test_case411" value="ALTER
TRIGGER modified_a ON main_table RENAME TO modified_modified_a;"
db-types="PostgreSQL" />
<sql-case id="alter_by_postgresql_source_test_case412" value="ALTER TYPE
bogon ADD VALUE 'bad';" db-types="PostgreSQL" />
<sql-case id="alter_by_postgresql_source_test_case413" value="ALTER TYPE
bogon ADD VALUE 'bad';" db-types="PostgreSQL" />
<sql-case id="alter_by_postgresql_source_test_case414" value="ALTER TYPE
bogon ADD VALUE 'ugly';" db-types="PostgreSQL" />
@@ -5209,7 +5208,6 @@
<sql-case id="low_alter_by_postgresql_source_test_case61" value="alter
table anothertab alter column atcol1 type boolean using case when
atcol1 % 2 = 0 then true else fa alter table anothertab drop constraint
anothertab_chk;" db-types="PostgreSQL" />
<sql-case id="low_alter_by_postgresql_source_test_case62" value="alter
table check_con_tbl add check (check_con_function(check_con_tbl.*));"
db-types="PostgreSQL" />
<sql-case id="low_alter_by_postgresql_source_test_case63" value="alter
table rename;" db-types="PostgreSQL" />
- <sql-case id="low_alter_by_postgresql_source_test_case67" value="alter
trigger a on grandparent rename to b;" db-types="PostgreSQL" />
<sql-case id="low_alter_by_postgresql_source_test_case68" value="alter
type alter1.ctype set schema alter1;" db-types="PostgreSQL" />
<sql-case id="low_alter_by_postgresql_source_test_case69" value="alter
type alter1.ctype set schema alter2;" db-types="PostgreSQL" />
<sql-case id="low_alter_by_postgresql_source_test_case70" value="alter
type comptype alter attribute r type bigint;" db-types="PostgreSQL" />
