This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new fa8c255baed Correct mismatched comments. (#20644)
fa8c255baed is described below
commit fa8c255baedb812d959f7c56bc04a5f6d20586ba
Author: yx9o <[email protected]>
AuthorDate: Mon Aug 29 23:09:36 2022 +0800
Correct mismatched comments. (#20644)
---
.../AbstractReadwriteSplittingRuleConfigurationChecker.java | 2 +-
.../distsql/handler/query/ShowMigrationListQueryResultSet.java | 2 +-
.../traffic/distsql/handler/query/TrafficRulesQueryResultSet.java | 2 +-
.../impl/migration/query/ShowMigrationStatusStatementAssert.java | 6 +++---
.../update/AddMigrationSourceResourceStatementAssert.java | 8 ++++----
.../update/DropMigrationSourceResourceStatementAssert.java | 6 +++---
.../migration/AddMigrationSourceResourceStatementTestCase.java | 2 +-
.../migration/DropMigrationSourceResourceStatementTestCase.java | 2 +-
8 files changed, 15 insertions(+), 15 deletions(-)
diff --git
a/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-core/src/main/java/org/apache/shardingsphere/readwritesplitting/checker/AbstractReadwriteSplittingRuleConfigurationChecker.java
b/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-core/src/main/java/org/apache/shardingsphere/readwritesplitting/checker/AbstractReadwriteSplittingRuleConfigurationChecker.java
index 219174fcede..9e41c525347 100644
---
a/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-core/src/main/java/org/apache/shardingsphere/readwritesplitting/checker/AbstractReadwriteSplittingRuleConfigurationChecker.java
+++
b/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-core/src/main/java/org/apache/shardingsphere/readwritesplitting/checker/AbstractReadwriteSplittingRuleConfigurationChecker.java
@@ -89,7 +89,7 @@ public abstract class
AbstractReadwriteSplittingRuleConfigurationChecker<T exten
final Map<String, DataSource>
dataSourceMap, final Collection<String> addedReadDataSourceNames, final String
readDataSourceName) {
for (String each : new
InlineExpressionParser(readDataSourceName).splitAndEvaluate()) {
Preconditions.checkState(dataSourceMap.containsKey(each), "Read
data source name `%s` not in database `%s`.", each, databaseName);
- Preconditions.checkState(addedReadDataSourceNames.add(each), "Can
not config duplicate write data source `%s` in database `%s`.", each,
databaseName);
+ Preconditions.checkState(addedReadDataSourceNames.add(each), "Can
not config duplicate read data source `%s` in database `%s`.", each,
databaseName);
}
}
diff --git
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/migration/distsql/handler/query/ShowMigrationListQueryResultSet.java
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/migration/distsql/handler/query/ShowMigrationListQueryResultSet.java
index a489a736b46..f82d8128ecb 100644
---
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/migration/distsql/handler/query/ShowMigrationListQueryResultSet.java
+++
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/migration/distsql/handler/query/ShowMigrationListQueryResultSet.java
@@ -31,7 +31,7 @@ import java.util.LinkedList;
import java.util.stream.Collectors;
/**
- * Query result set fpr show migration list.
+ * Query result set for show migration list.
*/
public final class ShowMigrationListQueryResultSet implements
DatabaseDistSQLResultSet {
diff --git
a/shardingsphere-kernel/shardingsphere-traffic/shardingsphere-traffic-distsql/shardingsphere-traffic-distsql-handler/src/main/java/org/apache/shardingsphere/traffic/distsql/handler/query/TrafficRulesQueryResultSet.java
b/shardingsphere-kernel/shardingsphere-traffic/shardingsphere-traffic-distsql/shardingsphere-traffic-distsql-handler/src/main/java/org/apache/shardingsphere/traffic/distsql/handler/query/TrafficRulesQueryResultSet.java
index 63c1b9f4f2c..55dae5ef47e 100644
---
a/shardingsphere-kernel/shardingsphere-traffic/shardingsphere-traffic-distsql/shardingsphere-traffic-distsql-handler/src/main/java/org/apache/shardingsphere/traffic/distsql/handler/query/TrafficRulesQueryResultSet.java
+++
b/shardingsphere-kernel/shardingsphere-traffic/shardingsphere-traffic-distsql/shardingsphere-traffic-distsql-handler/src/main/java/org/apache/shardingsphere/traffic/distsql/handler/query/TrafficRulesQueryResultSet.java
@@ -35,7 +35,7 @@ import java.util.LinkedList;
import java.util.Optional;
/**
- * Query result set for traffic rule..
+ * Query result set for traffic rule.
*/
public final class TrafficRulesQueryResultSet implements
GlobalRuleDistSQLResultSet {
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/query/ShowMigrationStatusStatementAssert.java
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/query/ShowMigrationStatusStatementAssert.java
index b2c050eddef..62bcb587ab0 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/query/ShowMigrationStatusStatementAssert.java
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/query/ShowMigrationStatusStatementAssert.java
@@ -34,11 +34,11 @@ import static org.junit.Assert.assertThat;
public final class ShowMigrationStatusStatementAssert {
/**
- * Assert show migration status is correct with expected parser result.
+ * Assert show migration status statement is correct with expected parser
result.
*
* @param assertContext assert context
- * @param actual actual check migration statement
- * @param expected expected check migration statement test case
+ * @param actual actual show migration status statement
+ * @param expected expected show migration status statement test case
*/
public static void assertIs(final SQLCaseAssertContext assertContext,
final ShowMigrationStatusStatement actual, final
ShowMigrationStatusStatementTestCase expected) {
if (null == expected) {
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/AddMigrationSourceResourceStatementAssert.java
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/AddMigrationSourceResourceStatementAssert.java
index 35389687910..e3678934341 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/AddMigrationSourceResourceStatementAssert.java
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/AddMigrationSourceResourceStatementAssert.java
@@ -35,17 +35,17 @@ import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertThat;
/**
- * Add Resource statement assert.
+ * Add migration source resource statement assert.
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class AddMigrationSourceResourceStatementAssert {
/**
- * Assert add resource statement is correct with expected parser result.
+ * Assert add migration source resource statement is correct with expected
parser result.
*
* @param assertContext assert context
- * @param actual actual add resource statement
- * @param expected expected add resource statement test case
+ * @param actual actual add migration source resource statement
+ * @param expected expected add migration source resource statement test
case
*/
public static void assertIs(final SQLCaseAssertContext assertContext,
final AddMigrationSourceResourceStatement actual, final
AddMigrationSourceResourceStatementTestCase expected) {
if (null == expected) {
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/DropMigrationSourceResourceStatementAssert.java
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/DropMigrationSourceResourceStatementAssert.java
index d5adf906ebc..bbb7e9c8cac 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/DropMigrationSourceResourceStatementAssert.java
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/DropMigrationSourceResourceStatementAssert.java
@@ -28,7 +28,7 @@ import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertThat;
/**
- * Drop Resource statement assert.
+ * Drop migration source resource statement assert.
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class DropMigrationSourceResourceStatementAssert {
@@ -37,8 +37,8 @@ public final class DropMigrationSourceResourceStatementAssert
{
* Assert drop migration source resource statement is correct with
expected parser result.
*
* @param assertContext assert context
- * @param actual actual drop resource statement
- * @param expected expected drop resource statement test case
+ * @param actual actual drop migration source resource statement
+ * @param expected expected drop migration source resource statement test
case
*/
public static void assertIs(final SQLCaseAssertContext assertContext,
final DropMigrationSourceResourceStatement actual, final
DropMigrationSourceResourceStatementTestCase expected) {
if (null == expected.getDataSources()) {
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/AddMigrationSourceResourceStatementTestCase.java
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/AddMigrationSourceResourceStatementTestCase.java
index 6cec74dd815..dcde2285945 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/AddMigrationSourceResourceStatementTestCase.java
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/AddMigrationSourceResourceStatementTestCase.java
@@ -26,7 +26,7 @@ import java.util.LinkedList;
import java.util.List;
/**
- * Add migration statement test case.
+ * Add migration source resource statement test case.
*/
@Getter
public final class AddMigrationSourceResourceStatementTestCase extends
SQLParserTestCase {
diff --git
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/DropMigrationSourceResourceStatementTestCase.java
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/DropMigrationSourceResourceStatementTestCase.java
index 1d66481e98e..4ad8da5c3fd 100644
---
a/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/DropMigrationSourceResourceStatementTestCase.java
+++
b/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/DropMigrationSourceResourceStatementTestCase.java
@@ -25,7 +25,7 @@ import java.util.LinkedList;
import java.util.List;
/**
- * Drop migration statement test case.
+ * Drop migration source resource statement test case.
*/
@Getter
public final class DropMigrationSourceResourceStatementTestCase extends
SQLParserTestCase {