zjcnb commented on code in PR #20689:
URL: https://github.com/apache/shardingsphere/pull/20689#discussion_r959675427
##########
shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/refresher/type/DropViewStatementSchemaRefresher.java:
##########
@@ -39,8 +39,9 @@ public final class DropViewStatementSchemaRefresher
implements MetaDataRefresher
public Optional<MetaDataRefreshedEvent> refresh(final
ShardingSphereDatabase database, final Collection<String> logicDataSourceNames,
final String schemaName,
final DropViewStatement sqlStatement, final ConfigurationProperties props)
throws SQLException {
SchemaAlteredEvent event = new SchemaAlteredEvent(database.getName(),
schemaName);
+ // TODO Drop view meta data from ShardingSphereSchema 's views
Review Comment:
i will adjustment notes
##########
shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/refresher/type/DropViewStatementSchemaRefresher.java:
##########
@@ -39,8 +39,9 @@ public final class DropViewStatementSchemaRefresher
implements MetaDataRefresher
public Optional<MetaDataRefreshedEvent> refresh(final
ShardingSphereDatabase database, final Collection<String> logicDataSourceNames,
final String schemaName,
final DropViewStatement sqlStatement, final ConfigurationProperties props)
throws SQLException {
SchemaAlteredEvent event = new SchemaAlteredEvent(database.getName(),
schemaName);
+ // TODO Drop view meta data from ShardingSphereSchema 's views
Review Comment:
I will adjustment notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
