This is an automated email from the ASF dual-hosted git repository.
yx9o pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 379d6e05301 Add missing javadoc (#20705)
379d6e05301 is described below
commit 379d6e05301347aec2ffa1f60775883156c96beb
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Sep 1 13:28:34 2022 +0800
Add missing javadoc (#20705)
* Reuse SQLExceptionTransformEngine in jdbc module
* Fix checkstyle
* Fix test cases
* Add missing javadoc
* Add missing javadoc
---
.../DatabaseDiscoveryRuleBeanDefinitionTag.java | 18 ++++++
.../tag/EncryptRuleBeanDefinitionTag.java | 30 ++++++++++
.../ReadwriteSplittingRuleBeanDefinitionTag.java | 12 ++++
.../namespace/tag/ShadowRuleBeanDefinitionTag.java | 33 +++++++++++
.../rule/ShardingRuleBeanDefinitionParser.java | 2 +-
.../tag/rule/ShardingRuleBeanDefinitionTag.java | 68 +++++++++++++++++++++-
.../handler/SQLParserNamespaceHandler.java | 2 +-
.../parser/CacheOptionBeanDefinitionParser.java | 4 +-
.../parser/SQLParserRuleBeanDefinitionParser.java | 6 +-
.../tag/SQLParserRuleBeanDefinitionTag.java | 33 +++++++++--
.../SQLTranslatorRuleBeanDefinitionParser.java | 4 +-
.../tag/SQLTranslatorRuleBeanDefinitionTag.java | 13 ++++-
12 files changed, 207 insertions(+), 18 deletions(-)
diff --git
a/shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-spring/shardingsphere-db-discovery-spring-namespace/src/main/java/org/apache/shardingsphere/dbdiscovery/spring/namespace/tag/DatabaseDiscoveryRuleBeanDefinitionTag.java
b/shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-spring/shardingsphere-db-discovery-spring-namespace/src/main/java/org/apache/shardingsphere/dbdiscovery/spring/namespace/tag/DatabaseDiscoveryRuleBea
[...]
index 620c8121b0b..cec7fbc01ad 100644
---
a/shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-spring/shardingsphere-db-discovery-spring-namespace/src/main/java/org/apache/shardingsphere/dbdiscovery/spring/namespace/tag/DatabaseDiscoveryRuleBeanDefinitionTag.java
+++
b/shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-spring/shardingsphere-db-discovery-spring-namespace/src/main/java/org/apache/shardingsphere/dbdiscovery/spring/namespace/tag/DatabaseDiscoveryRuleBeanDefinitionTag.java
@@ -26,15 +26,33 @@ import lombok.NoArgsConstructor;
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class DatabaseDiscoveryRuleBeanDefinitionTag {
+ /**
+ * Root tag.
+ */
public static final String ROOT_TAG = "rule";
+ /**
+ * Data source rule tag.
+ */
public static final String DATA_SOURCE_TAG = "data-source-rule";
+ /**
+ * Database discovery data source id attribute.
+ */
public static final String DB_DISCOVERY_DATA_SOURCE_ID_ATTRIBUTE = "id";
+ /**
+ * Database discovery data source names attribute.
+ */
public static final String DB_DISCOVERY_DATASOURCE_NAMES_ATTRIBUTE =
"data-source-names";
+ /**
+ * Database discovery heartbeat name attribute.
+ */
public static final String DB_DISCOVERY_HEARTBEAT_NAME_ATTRIBUTE =
"discovery-heartbeat-name";
+ /**
+ * Database discovery type name attribute.
+ */
public static final String DB_DISCOVERY_TYPE_NAME_ATTRIBUTE =
"discovery-type-name";
}
diff --git
a/shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-spring/shardingsphere-encrypt-spring-namespace/src/main/java/org/apache/shardingsphere/encrypt/spring/namespace/tag/EncryptRuleBeanDefinitionTag.java
b/shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-spring/shardingsphere-encrypt-spring-namespace/src/main/java/org/apache/shardingsphere/encrypt/spring/namespace/tag/EncryptRuleBeanDefinitionTag.java
index eb0bf75d4e1..2e26f5c8a89 100644
---
a/shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-spring/shardingsphere-encrypt-spring-namespace/src/main/java/org/apache/shardingsphere/encrypt/spring/namespace/tag/EncryptRuleBeanDefinitionTag.java
+++
b/shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-spring/shardingsphere-encrypt-spring-namespace/src/main/java/org/apache/shardingsphere/encrypt/spring/namespace/tag/EncryptRuleBeanDefinitionTag.java
@@ -26,23 +26,53 @@ import lombok.NoArgsConstructor;
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class EncryptRuleBeanDefinitionTag {
+ /**
+ * Root tag.
+ */
public static final String ROOT_TAG = "rule";
+ /**
+ * Table tag.
+ */
public static final String TABLE_TAG = "table";
+ /**
+ * Column tag.
+ */
public static final String COLUMN_TAG = "column";
+ /**
+ * Logic column attribute.
+ */
public static final String LOGIC_COLUMN_ATTRIBUTE = "logic-column";
+ /**
+ * Cipher column attribute.
+ */
public static final String CIPHER_COLUMN_ATTRIBUTE = "cipher-column";
+ /**
+ * Assisted query column attribute.
+ */
public static final String ASSISTED_QUERY_COLUMN_ATTRIBUTE =
"assisted-query-column";
+ /**
+ * Plain column attribute.
+ */
public static final String PLAIN_COLUMN_ATTRIBUTE = "plain-column";
+ /**
+ * Encrypt algorithm ref attribute.
+ */
public static final String ENCRYPT_ALGORITHM_REF_ATTRIBUTE =
"encrypt-algorithm-ref";
+ /**
+ * Assisted query encrypt algorithm ref attribute.
+ */
public static final String ASSISTED_QUERY_ENCRYPT_ALGORITHM_REF_ATTRIBUTE
= "assisted-query-encrypt-algorithm-ref";
+ /**
+ * Query with cipher column attribute.
+ */
public static final String QUERY_WITH_CIPHER_COLUMN =
"query-with-cipher-column";
}
diff --git
a/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-spring/shardingsphere-readwrite-splitting-spring-namespace/src/main/java/org/apache/shardingsphere/readwritesplitting/spring/namespace/tag/ReadwriteSplittingRuleBeanDefinitionTag.java
b/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-spring/shardingsphere-readwrite-splitting-spring-namespace/src/main/java/org/apache/shardingsphere/readwri
[...]
index f9df058d1af..ea061e6fffc 100644
---
a/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-spring/shardingsphere-readwrite-splitting-spring-namespace/src/main/java/org/apache/shardingsphere/readwritesplitting/spring/namespace/tag/ReadwriteSplittingRuleBeanDefinitionTag.java
+++
b/shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-spring/shardingsphere-readwrite-splitting-spring-namespace/src/main/java/org/apache/shardingsphere/readwritesplitting/spring/namespace/tag/ReadwriteSplittingRuleBeanDefinitionTag.java
@@ -26,11 +26,23 @@ import lombok.NoArgsConstructor;
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class ReadwriteSplittingRuleBeanDefinitionTag {
+ /**
+ * Root tag.
+ */
public static final String ROOT_TAG = "rule";
+ /**
+ * Data source tag.
+ */
public static final String DATA_SOURCE_TAG = "data-source-rule";
+ /**
+ * Readwrite splitting data source id attribute.
+ */
public static final String READWRITE_SPLITTING_DATA_SOURCE_ID_ATTRIBUTE =
"id";
+ /**
+ * Load balance algorithm ref attribute.
+ */
public static final String LOAD_BALANCE_ALGORITHM_REF_ATTRIBUTE =
"load-balance-algorithm-ref";
}
diff --git
a/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-spring/shardingsphere-shadow-spring-namespace/src/main/java/org/apache/shardingsphere/shadow/spring/namespace/tag/ShadowRuleBeanDefinitionTag.java
b/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-spring/shardingsphere-shadow-spring-namespace/src/main/java/org/apache/shardingsphere/shadow/spring/namespace/tag/ShadowRuleBeanDefinitionTag.java
index 9bcc443f550..19a5fd7941d 100644
---
a/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-spring/shardingsphere-shadow-spring-namespace/src/main/java/org/apache/shardingsphere/shadow/spring/namespace/tag/ShadowRuleBeanDefinitionTag.java
+++
b/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-spring/shardingsphere-shadow-spring-namespace/src/main/java/org/apache/shardingsphere/shadow/spring/namespace/tag/ShadowRuleBeanDefinitionTag.java
@@ -26,25 +26,58 @@ import lombok.NoArgsConstructor;
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class ShadowRuleBeanDefinitionTag {
+ /**
+ * Root tag.
+ */
public static final String ROOT_TAG = "rule";
+ /**
+ * Data source tag.
+ */
public static final String DATA_SOURCE_TAG = "data-source";
+ /**
+ * Data source id attribute.
+ */
public static final String DATA_SOURCE_ID_ATTRIBUTE = "id";
+ /**
+ * Shadow name attribute.
+ */
public static final String SHADOW_NAME_ATTRIBUTE = "name";
+ /**
+ * Production data source name attribute.
+ */
public static final String PRODUCTION_DATA_SOURCE_NAME_ATTRIBUTE =
"production-data-source-name";
+ /**
+ * Shadow data source name attribute.
+ */
public static final String SHADOW_DATA_SOURCE_NAME_ATTRIBUTE =
"shadow-data-source-name";
+ /**
+ * Shadow table attribute.
+ */
public static final String SHADOW_TABLE_TAG = "shadow-table";
+ /**
+ * Default shadow algorithm-name attribute.
+ */
public static final String SHADOW_DEFAULT_SHADOW_ALGORITHM_NAME =
"default-shadow-algorithm-name";
+ /**
+ * Data sources attribute.
+ */
public static final String SHADOW_TABLE_DATA_SOURCE_REFS_ATTRIBUTE =
"data-sources";
+ /**
+ * Algorithm tag.
+ */
public static final String SHADOW_TABLE_ALGORITHM_TAG = "algorithm";
+ /**
+ * Shadow algorithm ref.
+ */
public static final String SHADOW_TABLE_ALGORITHM_REF_ATTRIBUTE =
"shadow-algorithm-ref";
}
diff --git
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/parser/rule/ShardingRuleBeanDefinitionParser.java
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/parser/rule/ShardingRuleBeanDefinitionParser.java
index 63f08ea20b0..6514c169581 100644
---
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/parser/rule/ShardingRuleBeanDefinitionParser.java
+++
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/parser/rule/ShardingRuleBeanDefinitionParser.java
@@ -194,7 +194,7 @@ public final class ShardingRuleBeanDefinitionParser extends
AbstractBeanDefiniti
}
private void setDefaultShardingColumn(final Element element, final
BeanDefinitionBuilder factory) {
- String defaultShardingColumn =
element.getAttribute(ShardingRuleBeanDefinitionTag.DEFAULT_SHARDING_COLUMN);
+ String defaultShardingColumn =
element.getAttribute(ShardingRuleBeanDefinitionTag.DEFAULT_SHARDING_COLUMN_ATTRIBUTE);
if (!Strings.isNullOrEmpty(defaultShardingColumn)) {
factory.addPropertyValue("defaultShardingColumn",
defaultShardingColumn);
}
diff --git
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/tag/rule/ShardingRuleBeanDefinitionTag.java
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/tag/rule/ShardingRuleBeanDefinitionTag.java
index 6197568eec1..37877755eb4 100644
---
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/tag/rule/ShardingRuleBeanDefinitionTag.java
+++
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/main/java/org/apache/shardingsphere/sharding/spring/namespace/tag/rule/ShardingRuleBeanDefinitionTag.java
@@ -26,47 +26,113 @@ import lombok.NoArgsConstructor;
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class ShardingRuleBeanDefinitionTag {
+ /**
+ * Root tag.
+ */
public static final String ROOT_TAG = "rule";
+ /**
+ * Table rules tag.
+ */
public static final String TABLE_RULES_TAG = "table-rules";
+ /**
+ * Auto table rules tag.
+ */
public static final String AUTO_TABLE_RULES_TAG = "auto-table-rules";
+ /**
+ * Table rule tag.
+ */
public static final String TABLE_RULE_TAG = "table-rule";
+ /**
+ * Auto table rule tag.
+ */
public static final String AUTO_TABLE_RULE_TAG = "auto-table-rule";
+ /**
+ * Binding table rules tag.
+ */
public static final String BINDING_TABLE_RULES_TAG = "binding-table-rules";
+ /**
+ * Binding table rule tag.
+ */
public static final String BINDING_TABLE_RULE_TAG = "binding-table-rule";
+ /**
+ * Logic table attribute.
+ */
public static final String LOGIC_TABLE_ATTRIBUTE = "logic-table";
+ /**
+ * Logic tables attribute.
+ */
public static final String LOGIC_TABLES_ATTRIBUTE = "logic-tables";
+ /**
+ * Broadcast table rules tag.
+ */
public static final String BROADCAST_TABLE_RULES_TAG =
"broadcast-table-rules";
+ /**
+ * Broadcast table rule tag.
+ */
public static final String BROADCAST_TABLE_RULE_TAG =
"broadcast-table-rule";
+ /**
+ * Table tag.
+ */
public static final String TABLE_ATTRIBUTE = "table";
+ /**
+ * Actual data nodes attribute.
+ */
public static final String ACTUAL_DATA_NODES_ATTRIBUTE =
"actual-data-nodes";
+ /**
+ * Actual data sources attribute.
+ */
public static final String ACTUAL_DATA_SOURCES_ATTRIBUTE =
"actual-data-sources";
+ /**
+ * Database strategy ref attribute.
+ */
public static final String DATABASE_STRATEGY_REF_ATTRIBUTE =
"database-strategy-ref";
+ /**
+ * Table strategy ref attribute.
+ */
public static final String TABLE_STRATEGY_REF_ATTRIBUTE =
"table-strategy-ref";
+ /**
+ * Sharding strategy ref attribute.
+ */
public static final String SHARDING_STRATEGY_REF_ATTRIBUTE =
"sharding-strategy-ref";
+ /**
+ * Default database strategy ref attribute.
+ */
public static final String DEFAULT_DATABASE_STRATEGY_REF_ATTRIBUTE =
"default-database-strategy-ref";
+ /**
+ * Default table strategy ref attribute.
+ */
public static final String DEFAULT_TABLE_STRATEGY_REF_ATTRIBUTE =
"default-table-strategy-ref";
+ /**
+ * Key generate strategy ref attribute.
+ */
public static final String STRATEGY_REF_ATTRIBUTE =
"key-generate-strategy-ref";
+ /**
+ * Default key generate strategy ref attribute.
+ */
public static final String DEFAULT_KEY_GENERATE_STRATEGY_REF_ATTRIBUTE =
"default-key-generate-strategy-ref";
- public static final String DEFAULT_SHARDING_COLUMN =
"default-sharding-column";
+ /**
+ * Default sharding column attribute.
+ */
+ public static final String DEFAULT_SHARDING_COLUMN_ATTRIBUTE =
"default-sharding-column";
}
diff --git
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/handler/SQLParserNamespaceHandler.java
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/handler/SQLParserNamespaceHandler.java
index 84b615b772e..7bd747c57ac 100644
---
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/handler/SQLParserNamespaceHandler.java
+++
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/handler/SQLParserNamespaceHandler.java
@@ -30,6 +30,6 @@ public final class SQLParserNamespaceHandler extends
NamespaceHandlerSupport {
@Override
public void init() {
registerBeanDefinitionParser(SQLParserRuleBeanDefinitionTag.ROOT_TAG,
new SQLParserRuleBeanDefinitionParser());
-
registerBeanDefinitionParser(SQLParserRuleBeanDefinitionTag.CACHE_OPTION, new
CacheOptionBeanDefinitionParser());
+
registerBeanDefinitionParser(SQLParserRuleBeanDefinitionTag.CACHE_OPTION_ATTRIBUTE,
new CacheOptionBeanDefinitionParser());
}
}
diff --git
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/CacheOptionBeanDefinitionParser.java
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/CacheOptionBeanDefinitionParser.java
index 996e344a1a1..873cacbc08e 100644
---
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/CacheOptionBeanDefinitionParser.java
+++
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/CacheOptionBeanDefinitionParser.java
@@ -33,8 +33,8 @@ public final class CacheOptionBeanDefinitionParser extends
AbstractBeanDefinitio
@Override
protected AbstractBeanDefinition parseInternal(final Element element,
final ParserContext parserContext) {
BeanDefinitionBuilder factory =
BeanDefinitionBuilder.rootBeanDefinition(CacheOption.class);
-
factory.addConstructorArgValue(element.getAttribute(SQLParserRuleBeanDefinitionTag.INITIAL_CAPACITY));
-
factory.addConstructorArgValue(element.getAttribute(SQLParserRuleBeanDefinitionTag.MAXIMUM_SIZE));
+
factory.addConstructorArgValue(element.getAttribute(SQLParserRuleBeanDefinitionTag.INITIAL_CAPACITY_ATTRIBUTE));
+
factory.addConstructorArgValue(element.getAttribute(SQLParserRuleBeanDefinitionTag.MAXIMUM_SIZE_ATTRIBUTE));
return factory.getBeanDefinition();
}
}
diff --git
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/SQLParserRuleBeanDefinitionParser.java
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/SQLParserRuleBeanDefinitionParser.java
index c162e6b8d70..51706272ac8 100644
---
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/SQLParserRuleBeanDefinitionParser.java
+++
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/parser/SQLParserRuleBeanDefinitionParser.java
@@ -33,9 +33,9 @@ public final class SQLParserRuleBeanDefinitionParser extends
AbstractBeanDefinit
@Override
protected AbstractBeanDefinition parseInternal(final Element element,
final ParserContext parserContext) {
BeanDefinitionBuilder factory =
BeanDefinitionBuilder.rootBeanDefinition(SQLParserRuleConfiguration.class);
-
factory.addConstructorArgValue(Boolean.parseBoolean(element.getAttribute(SQLParserRuleBeanDefinitionTag.SQL_COMMENT_PARSER_ENABLE)));
-
factory.addConstructorArgReference(element.getAttribute(SQLParserRuleBeanDefinitionTag.PARSE_TREE_CACHE_REF));
-
factory.addConstructorArgReference(element.getAttribute(SQLParserRuleBeanDefinitionTag.SQL_STATEMENT_CACHE_REF));
+
factory.addConstructorArgValue(Boolean.parseBoolean(element.getAttribute(SQLParserRuleBeanDefinitionTag.SQL_COMMENT_PARSER_ENABLE_ATTRIBUTE)));
+
factory.addConstructorArgReference(element.getAttribute(SQLParserRuleBeanDefinitionTag.PARSE_TREE_CACHE_REF_ATTRIBUTE));
+
factory.addConstructorArgReference(element.getAttribute(SQLParserRuleBeanDefinitionTag.SQL_STATEMENT_CACHE_REF_ATTRIBUTE));
return factory.getBeanDefinition();
}
}
diff --git
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/tag/SQLParserRuleBeanDefinitionTag.java
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/tag/SQLParserRuleBeanDefinitionTag.java
index 77ff38c4d84..b6f692f79f3 100644
---
a/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/tag/SQLParserRuleBeanDefinitionTag.java
+++
b/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-spring/shardingsphere-parser-spring-namespace/src/main/java/org/apache/shardingsphere/parser/spring/namespace/tag/SQLParserRuleBeanDefinitionTag.java
@@ -26,17 +26,38 @@ import lombok.NoArgsConstructor;
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class SQLParserRuleBeanDefinitionTag {
+ /**
+ * Root tag.
+ */
public static final String ROOT_TAG = "rule";
- public static final String SQL_COMMENT_PARSER_ENABLE =
"sql-comment-parse-enable";
+ /**
+ * SQL comment parse enable attribute.
+ */
+ public static final String SQL_COMMENT_PARSER_ENABLE_ATTRIBUTE =
"sql-comment-parse-enable";
- public static final String SQL_STATEMENT_CACHE_REF =
"sql-statement-cache-ref";
+ /**
+ * SQL statement cache ref attribute.
+ */
+ public static final String SQL_STATEMENT_CACHE_REF_ATTRIBUTE =
"sql-statement-cache-ref";
- public static final String PARSE_TREE_CACHE_REF = "parse-tree-cache-ref";
+ /**
+ * Parse tree cache ref attribute.
+ */
+ public static final String PARSE_TREE_CACHE_REF_ATTRIBUTE =
"parse-tree-cache-ref";
- public static final String INITIAL_CAPACITY = "initial-capacity";
+ /**
+ * Initial capacity attribute.
+ */
+ public static final String INITIAL_CAPACITY_ATTRIBUTE = "initial-capacity";
- public static final String MAXIMUM_SIZE = "maximum-size";
+ /**
+ * Maximum size attribute.
+ */
+ public static final String MAXIMUM_SIZE_ATTRIBUTE = "maximum-size";
- public static final String CACHE_OPTION = "cache-option";
+ /**
+ * Cache option attribute.
+ */
+ public static final String CACHE_OPTION_ATTRIBUTE = "cache-option";
}
diff --git
a/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/parser/SQLTranslatorRuleBeanDefinitionParser.java
b/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/parser/SQLTran
[...]
index 3ee701dbb25..f7db476ba64 100644
---
a/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/parser/SQLTranslatorRuleBeanDefinitionParser.java
+++
b/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/parser/SQLTranslatorRuleBeanDefinitionParser.java
@@ -33,8 +33,8 @@ public final class SQLTranslatorRuleBeanDefinitionParser
extends AbstractBeanDef
@Override
protected AbstractBeanDefinition parseInternal(final Element element,
final ParserContext parserContext) {
BeanDefinitionBuilder factory =
BeanDefinitionBuilder.rootBeanDefinition(SQLTranslatorRuleConfiguration.class);
-
factory.addConstructorArgValue(element.getAttribute(SQLTranslatorRuleBeanDefinitionTag.SQL_TRANSLATOR_TYPE));
-
factory.addConstructorArgValue(Boolean.parseBoolean(element.getAttribute(SQLTranslatorRuleBeanDefinitionTag.SQL_USE_ORIGINAL_SQL_WHEN_TRANSLATING_FAILED)));
+
factory.addConstructorArgValue(element.getAttribute(SQLTranslatorRuleBeanDefinitionTag.SQL_TRANSLATOR_TYPE_ATTRIBUTE));
+
factory.addConstructorArgValue(Boolean.parseBoolean(element.getAttribute(SQLTranslatorRuleBeanDefinitionTag.SQL_USE_ORIGINAL_SQL_WHEN_TRANSLATING_FAILED_ATTRIBUTE)));
return factory.getBeanDefinition();
}
}
diff --git
a/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/tag/SQLTranslatorRuleBeanDefinitionTag.java
b/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/tag/SQLTranslatorRul
[...]
index 715deae895b..cc6f891effd 100644
---
a/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/tag/SQLTranslatorRuleBeanDefinitionTag.java
+++
b/shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-spring/shardingsphere-sql-translator-spring-namespace/src/main/java/org/apache/shardingsphere/sqltranslator/spring/namespace/tag/SQLTranslatorRuleBeanDefinitionTag.java
@@ -26,9 +26,18 @@ import lombok.NoArgsConstructor;
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class SQLTranslatorRuleBeanDefinitionTag {
+ /**
+ * Root tag.
+ */
public static final String ROOT_TAG = "rule";
- public static final String SQL_TRANSLATOR_TYPE = "type";
+ /**
+ * SQL translator type attribute.
+ */
+ public static final String SQL_TRANSLATOR_TYPE_ATTRIBUTE = "type";
- public static final String SQL_USE_ORIGINAL_SQL_WHEN_TRANSLATING_FAILED =
"use-original-sql-when-translating-failed";
+ /**
+ * Use original SQL when translating failed attribute.
+ */
+ public static final String
SQL_USE_ORIGINAL_SQL_WHEN_TRANSLATING_FAILED_ATTRIBUTE =
"use-original-sql-when-translating-failed";
}
