This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new c57c4144563 [Issue #20377]-Improved coverage for
AlterIndexStatementHandler (#20796)
c57c4144563 is described below
commit c57c4144563730d143a2307d9fc05e5f5c7d7381
Author: Abhinav Koppula <[email protected]>
AuthorDate: Mon Sep 5 15:44:45 2022 +0530
[Issue #20377]-Improved coverage for AlterIndexStatementHandler (#20796)
* [Issue #20377]-Improved coverage for AlterIndexStatementHandler
* [ReviewComment]-Removed unnecessary blank line
---
.../ddl/AlterIndexStatementHandlerTest.java | 33 ++++++++++++++++++++--
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterIndexStatementHandlerTest.java
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterIndexStatementHandlerTest.java
index f9ab1d173dc..0300f980a20 100644
---
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterIndexStatementHandlerTest.java
+++
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterIndexStatementHandlerTest.java
@@ -17,20 +17,24 @@
package org.apache.shardingsphere.sql.parser.sql.dialect.handler.ddl;
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertTrue;
+
import
org.apache.shardingsphere.sql.parser.sql.common.segment.ddl.index.IndexNameSegment;
import
org.apache.shardingsphere.sql.parser.sql.common.segment.ddl.index.IndexSegment;
import
org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.SimpleTableSegment;
import
org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.TableNameSegment;
import
org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.ddl.OpenGaussAlterIndexStatement;
+import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleAlterIndexStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterIndexStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.sqlserver.ddl.SQLServerAlterIndexStatement;
import org.junit.Test;
import java.util.Optional;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-
public final class AlterIndexStatementHandlerTest {
@Test
@@ -62,4 +66,27 @@ public final class AlterIndexStatementHandlerTest {
Optional<IndexSegment> indexSegment =
AlterIndexStatementHandler.getRenameIndexSegment(alterIndexStatement);
assertFalse(indexSegment.isPresent());
}
+
+ @Test
+ public void assertGetRenameIndexSegmentForOpenGauss() {
+ IndexSegment indexSegment = new IndexSegment(0, 0, new
IndexNameSegment(0, 0, new IdentifierValue("")));
+ OpenGaussAlterIndexStatement alterIndexStatement = new
OpenGaussAlterIndexStatement();
+ alterIndexStatement.setRenameIndex(indexSegment);
+ Optional<IndexSegment> actual =
AlterIndexStatementHandler.getRenameIndexSegment(alterIndexStatement);
+ assertTrue(actual.isPresent());
+ assertThat(actual.get(), is(indexSegment));
+ }
+
+ @Test
+ public void assertGetSimpleTableSegmentForOtherDatabases() {
+ assertFalse(AlterIndexStatementHandler.getSimpleTableSegment(new
OpenGaussAlterIndexStatement()).isPresent());
+ assertFalse(AlterIndexStatementHandler.getSimpleTableSegment(new
OracleAlterIndexStatement()).isPresent());
+ assertFalse(AlterIndexStatementHandler.getSimpleTableSegment(new
PostgreSQLAlterIndexStatement()).isPresent());
+ }
+
+ @Test
+ public void assertGetRenameIndexSegmentForOtherDatabases() {
+ assertFalse(AlterIndexStatementHandler.getRenameIndexSegment(new
OracleAlterIndexStatement()).isPresent());
+ assertFalse(AlterIndexStatementHandler.getRenameIndexSegment(new
SQLServerAlterIndexStatement()).isPresent());
+ }
}