This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 8b929189bd1 [Issue #20375]-Improve coverage for
DropIndexStatementHandler (#20803)
8b929189bd1 is described below
commit 8b929189bd192ba6145dcc6ed28bf2bd8f61e759
Author: Abhinav Koppula <[email protected]>
AuthorDate: Tue Sep 6 05:30:31 2022 +0530
[Issue #20375]-Improve coverage for DropIndexStatementHandler (#20803)
---
.../handler/ddl/DropIndexStatementHandlerTest.java | 34 ++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropIndexStatementHandlerTest.java
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropIndexStatementHandlerTest.java
index 92c3d2693ae..723b87cfa06 100644
---
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropIndexStatementHandlerTest.java
+++
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropIndexStatementHandlerTest.java
@@ -21,6 +21,9 @@ import
org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.Sim
import
org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.TableNameSegment;
import
org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.ddl.MySQLDropIndexStatement;
+import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.ddl.OpenGaussDropIndexStatement;
+import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropIndexStatement;
+import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropIndexStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.sqlserver.ddl.SQLServerDropIndexStatement;
import org.junit.Test;
@@ -60,4 +63,35 @@ public final class DropIndexStatementHandlerTest {
Optional<SimpleTableSegment> simpleTableSegment =
DropIndexStatementHandler.getSimpleTableSegment(dropIndexStatement);
assertFalse(simpleTableSegment.isPresent());
}
+
+ @Test
+ public void assertGetSimpleTableSegmentForOtherDatabases() {
+ assertFalse(DropIndexStatementHandler.getSimpleTableSegment(new
OpenGaussDropIndexStatement(true)).isPresent());
+ assertFalse(DropIndexStatementHandler.getSimpleTableSegment(new
OracleDropIndexStatement()).isPresent());
+ assertFalse(DropIndexStatementHandler.getSimpleTableSegment(new
PostgreSQLDropIndexStatement(true)).isPresent());
+ }
+
+ @Test
+ public void assertIfExistsForPostgres() {
+ assertFalse(DropIndexStatementHandler.ifExists(new
PostgreSQLDropIndexStatement(false)));
+ assertTrue(DropIndexStatementHandler.ifExists(new
PostgreSQLDropIndexStatement(true)));
+ }
+
+ @Test
+ public void assertIfExistsForSQLServer() {
+ assertFalse(DropIndexStatementHandler.ifExists(new
SQLServerDropIndexStatement(false)));
+ assertTrue(DropIndexStatementHandler.ifExists(new
SQLServerDropIndexStatement(true)));
+ }
+
+ @Test
+ public void assertIfExistsForOpenGauss() {
+ assertFalse(DropIndexStatementHandler.ifExists(new
OpenGaussDropIndexStatement(false)));
+ assertTrue(DropIndexStatementHandler.ifExists(new
OpenGaussDropIndexStatement(true)));
+ }
+
+ @Test
+ public void assertIfExistsForOtherDatabases() {
+ assertFalse(DropIndexStatementHandler.ifExists(new
MySQLDropIndexStatement()));
+ assertFalse(DropIndexStatementHandler.ifExists(new
OracleDropIndexStatement()));
+ }
}