This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 40fd0da8039 Fix : fix a checkstyle issue (#20817)
40fd0da8039 is described below
commit 40fd0da8039b4e510ec333ec9bf93f77b50a0de4
Author: 孙念君 Nianjun Sun <[email protected]>
AuthorDate: Tue Sep 6 12:29:42 2022 +0800
Fix : fix a checkstyle issue (#20817)
---
.../infra/datasource/props/DataSourcePropertiesValidator.java | 3 ++-
.../jdbc/transaction/JDBCBackendTransactionManager.java | 2 +-
.../communication/jdbc/transaction/LocalTransactionManager.java | 2 +-
.../sql/dialect/handler/ddl/CreateIndexStatementHandlerTest.java | 6 +++---
.../sql/dialect/handler/ddl/CreateSchemaStatementHandlerTest.java | 2 +-
5 files changed, 8 insertions(+), 7 deletions(-)
diff --git
a/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/datasource/props/DataSourcePropertiesValidator.java
b/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/datasource/props/DataSourcePropertiesValidator.java
index c5a6ff5b0df..8636463ccc9 100644
---
a/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/datasource/props/DataSourcePropertiesValidator.java
+++
b/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/datasource/props/DataSourcePropertiesValidator.java
@@ -79,7 +79,8 @@ public final class DataSourcePropertiesValidator {
private void checkFailFast(final DataSource dataSource, final DatabaseType
databaseType) throws SQLException, ShardingSphereInternalException {
try (Connection connection = dataSource.getConnection()) {
- ShardingSpherePreconditions.checkState(null == databaseType ||
DatabaseTypeEngine.getDatabaseType(connection.getMetaData().getURL()).getType().equals(databaseType.getType()),
new MismatchedProtocolAndDataSourceException());
+ ShardingSpherePreconditions.checkState(null == databaseType
+ ||
DatabaseTypeEngine.getDatabaseType(connection.getMetaData().getURL()).getType().equals(databaseType.getType()),
new MismatchedProtocolAndDataSourceException());
}
}
}
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/JDBCBackendTransactionManager.java
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/JDBCBackendTransactionManager.java
index 56c57e3bd67..0b27977238d 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/JDBCBackendTransactionManager.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/JDBCBackendTransactionManager.java
@@ -161,7 +161,7 @@ public final class JDBCBackendTransactionManager implements
TransactionManager<V
if (0 == count) {
ex = each;
} else {
- // TODO use recursion to setNextException with chain, not
overlap
+ // TODO use recursion to setNextException with chain, not
overlap
ex.setNextException(each);
}
count++;
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/LocalTransactionManager.java
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/LocalTransactionManager.java
index ddc56784882..528fbb8cff2 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/LocalTransactionManager.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/transaction/LocalTransactionManager.java
@@ -121,7 +121,7 @@ public final class LocalTransactionManager implements
TransactionManager<Void> {
if (0 == count) {
ex = each;
} else {
- // TODO use recursion to setNextException with chain, not
overlap
+ // TODO use recursion to setNextException with chain, not
overlap
ex.setNextException(each);
}
count++;
diff --git
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateIndexStatementHandlerTest.java
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateIndexStatementHandlerTest.java
index 0f02eb2848a..feeabef18ec 100644
---
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateIndexStatementHandlerTest.java
+++
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateIndexStatementHandlerTest.java
@@ -40,7 +40,7 @@ public final class CreateIndexStatementHandlerTest {
assertFalse(CreateIndexStatementHandler.ifNotExists(new
OracleCreateIndexStatement()));
assertFalse(CreateIndexStatementHandler.ifNotExists(new
SQLServerCreateIndexStatement()));
}
-
+
@Test
public void assertGeneratedIndexStartIndexForPostgres() {
PostgreSQLCreateIndexStatement postgreSQLCreateIndexStatement = new
PostgreSQLCreateIndexStatement(true);
@@ -49,7 +49,7 @@ public final class CreateIndexStatementHandlerTest {
assertTrue(actual.isPresent());
assertThat(actual.get(), is(2));
}
-
+
@Test
public void assertGeneratedIndexStartIndexForOpenGauss() {
OpenGaussCreateIndexStatement openGaussCreateIndexStatement = new
OpenGaussCreateIndexStatement(true);
@@ -58,7 +58,7 @@ public final class CreateIndexStatementHandlerTest {
assertTrue(actual.isPresent());
assertThat(actual.get(), is(2));
}
-
+
@Test
public void assertGeneratedIndexStartIndexForOtherDatabases() {
assertFalse(CreateIndexStatementHandler.getGeneratedIndexStartIndex(new
MySQLCreateIndexStatement()).isPresent());
diff --git
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateSchemaStatementHandlerTest.java
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateSchemaStatementHandlerTest.java
index 930e522286b..d713298c0c2 100644
---
a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateSchemaStatementHandlerTest.java
+++
b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateSchemaStatementHandlerTest.java
@@ -49,7 +49,7 @@ public final class CreateSchemaStatementHandlerTest {
assertTrue(actual.isPresent());
assertThat(actual.get().getValue(), is("root"));
}
-
+
@Test
public void assertGetUsernameForSQLServerStatement() {
SQLServerCreateSchemaStatement createSchemaStatement = new
SQLServerCreateSchemaStatement();
