abhinav-koppula commented on code in PR #20778:
URL: https://github.com/apache/shardingsphere/pull/20778#discussion_r964714626


##########
shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactoryTest.java:
##########
@@ -53,18 +70,57 @@ public final class MetaDataContextsFactoryTest {
     
     @Mock
     private DatabaseMetaDataPersistService databaseMetaDataPersistService;
-    
+
+    @Mock
+    private ShardingSphereDatabase mockShardingSphereDb;
+
+    @Mock
+    private JDBCInstanceMetaData jdbcInstanceMetaData;
+
+    private final Properties properties = new Properties();
+
+    private final List<ShardingSphereRule> shardingSphereRules = new 
ArrayList<ShardingSphereRule>() {
+        {
+            add(new MockedRule());

Review Comment:
   Moved to setup, 
https://github.com/apache/shardingsphere/pull/20778/commits/802fc58ebc48f7e41ca1281a3fb7708442be5b32#diff-4d5951cc0f1eb8b3f9a46f67750ce90b78ca6d217d9f8e69c1e35985abf249e3R92



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to