tianhao960 commented on code in PR #20910:
URL: https://github.com/apache/shardingsphere/pull/20910#discussion_r967833118
##########
shardingsphere-test/shardingsphere-test-common/src/main/java/org/apache/shardingsphere/test/runner/parallel/annotaion/ParallelLevel.java:
##########
@@ -15,12 +15,12 @@
* limitations under the License.
*/
-package
org.apache.shardingsphere.test.integration.framework.runner.parallel.annotaion;
+package org.apache.shardingsphere.test.runner.parallel.annotaion;
/**
* Parallel level.
*/
public enum ParallelLevel {
- CASE, SCENARIO
+ CASE, SCENARIO, DEFAULT
Review Comment:
ParallelRunnerScheduler constructors use ParallelLevel as an input
parameter;
`ParallelRuntimeStrategy parallelRuntimeStrategy =
clazz.getAnnotation(ParallelRuntimeStrategy.class);
ParallelLevel level = null != parallelRuntimeStrategy ?
parallelRuntimeStrategy.value() : ParallelLevel.DEFAULT;
setScheduler(new ParallelRunnerScheduler(level, new
DefaultParallelRunnerExecutorFactory()));`
and I just don't want to use Case or Scenario as an default level which may
be cause an confusion that why not use CaseParallelRunnerExecutor or
ScenarioParallelRunnerExecutor as the executor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
