sandynz commented on code in PR #20967:
URL: https://github.com/apache/shardingsphere/pull/20967#discussion_r972835998
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/compose/DockerContainerComposer.java:
##########
@@ -65,7 +65,7 @@ public DockerContainerComposer(final DatabaseType
databaseType, final String sto
storageContainerConfig =
StorageContainerConfigurationFactory.newInstance(databaseType);
}
storageContainer =
getContainers().registerContainer((DockerStorageContainer)
StorageContainerFactory.newInstance(databaseType, storageContainerImage,
- "", storageContainerConfig));
+ "",
StorageContainerConfigurationFactory.newInstance(databaseType)));
Review Comment:
Seems it should use `storageContainerConfig`, but not create another instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
