sandynz commented on code in PR #21046: URL: https://github.com/apache/shardingsphere/pull/21046#discussion_r973828946
########## CODE_OF_CONDUCT.md: ########## @@ -63,7 +63,7 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND - Environment preparation codes should be separate from test codes. - Only those that relate to junit `Assert`, hamcrest `CoreMatchers` and `Mockito` can use static import. - For single parameter asserts, `assertTrue`, `assertFalse`, `assertNull` and `assertNotNull` should be used. - - For multiple parameter asserts, `assertThat` should be used. + - For multiple parameter asserts, `org.hamcrest.MatcherAssert.assertThat` should be used. Review Comment: 1, It might be better to put `MatcherAssert` in `Only those that relate to junit Assert, hamcrest CoreMatchers and Mockito can use static import.`, and keep `assertThat` simple. `org.junit.Assert.assertThat` is deprecated now, contributors will notice it in IDE. 2, Looks there's another `code.en.md` could be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
