azexcy commented on code in PR #21065:
URL: https://github.com/apache/shardingsphere/pull/21065#discussion_r974082107
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/InventoryIncrementalTasksRunner.java:
##########
@@ -151,15 +157,17 @@ private synchronized void executeIncrementalTask() {
private ExecuteCallback createIncrementalTaskCallback() {
return new ExecuteCallback() {
-
+
@Override
public void onSuccess() {
+ jobAPI.persistJobItemErrorMsg(jobItemContext.getJobId(),
jobItemContext.getShardingItem(), null);
}
@Override
public void onFailure(final Throwable throwable) {
log.error("Incremental task execute failed.", throwable);
updateLocalAndRemoteJobItemStatus(JobStatus.EXECUTE_INCREMENTAL_TASK_FAILURE);
+ jobAPI.persistJobItemErrorMsg(jobItemContext.getJobId(),
jobItemContext.getShardingItem(), throwable);
stop();
}
Review Comment:
1. yes
2. yes
the error like below
```
org.apache.shardingsphere.data.pipeline.core.exception.job.BinlogSyncChannelAlreadyClosedException
at
org.apache.shardingsphere.infra.util.exception.ShardingSpherePreconditions.checkState(ShardingSpherePreconditions.java:41)
at
org.apache.shardingsphere.data.pipeline.mysql.ingest.client.MySQLClient.poll(MySQLClient.java:210)
at
org.apache.shardingsphere.data.pipeline.mysql.ingest.MySQLIncrementalDumper.dump(MySQLIncrementalDumper.java:104)
at
org.apache.shardingsphere.data.pipeline.mysql.ingest.MySQLIncrementalDumper.doStart(MySQLIncrementalDumper.java:96)
at
org.apache.shardingsphere.data.pipeline.api.executor.AbstractLifecycleExecutor.start(AbstractLifecycleExecutor.java:41)
at
org.apache.shardingsphere.data.pipeline.core.task.IncrementalTask.doStart(IncrementalTask.java:93)
at
org.apache.shardingsphere.data.pipeline.api.executor.AbstractLifecycleExecutor.start(AbstractLifecycleExecutor.java:41)
at
org.apache.shardingsphere.data.pipeline.api.executor.AbstractLifecycleExecutor.run(AbstractLifecycleExecutor.java:61)
at
java.util.concurrent.CompletableFuture$AsyncRun.run$$$capture(CompletableFuture.java:1640)
at
java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
