sandynz commented on code in PR #21071:
URL: https://github.com/apache/shardingsphere/pull/21071#discussion_r975212226
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/cases/migration/general/MySQLMigrationGeneralIT.java:
##########
@@ -86,13 +91,13 @@ public void assertMigrationSuccess() throws SQLException,
InterruptedException {
JdbcTemplate jdbcTemplate = new JdbcTemplate(getSourceDataSource());
Pair<List<Object[]>, List<Object[]>> dataPair =
ScalingCaseHelper.generateFullInsertData(keyGenerateAlgorithm,
parameterized.getDatabaseType(), 3000);
log.info("init data begin: {}", LocalDateTime.now());
- jdbcTemplate.batchUpdate(getExtraSQLCommand().getFullInsertOrder(),
dataPair.getLeft());
+
jdbcTemplate.batchUpdate(String.format(getExtraSQLCommand().getFullInsertOrder(getSourceTableOrderName())),
dataPair.getLeft());
Review Comment:
Looks `getFullInsertOrder` does not need String.format any more
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/command/ExtraSQLCommand.java:
##########
@@ -33,11 +34,33 @@ public final class ExtraSQLCommand {
private String createTableOrder;
@XmlElement(name = "create-table-order-item")
+ @Getter
private String createTableOrderItem;
@XmlElement(name = "full-insert-order")
private String fullInsertOrder;
@XmlElement(name = "full-insert-order-item")
+ @Getter
private String fullInsertOrderItem;
+
+ /**
+ * Get migration single table DistSQL.
+ *
+ * @param orderTableName order table name
+ * @return migration single table DistSQL
+ */
Review Comment:
Looks javadoc doesn't match getFullInsertOrder method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
