TeslaCN commented on code in PR #21176:
URL: https://github.com/apache/shardingsphere/pull/21176#discussion_r979487128
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-standalone-mode/shardingsphere-standalone-mode-repository/shardingsphere-standalone-mode-repository-provider/shardingsphere-standalone-mode-repository-jdbc/shardingsphere-standalone-mode-repository-jdbc-core/src/main/java/org/apache/shardingsphere/mode/repository/standalone/jdbc/JDBCRepository.java:
##########
@@ -112,29 +117,29 @@ public List<String> getChildrenKeys(final String key) {
@Override
public void persist(final String key, final String value) {
- String[] paths = Arrays.stream(key.split(SEPARATOR)).filter(each ->
!Strings.isNullOrEmpty(each)).toArray(String[]::new);
- String tempPrefix = "";
- String parent = SEPARATOR;
try {
+ String keyValue = get(key);
Review Comment:
How about naming it `oldValue`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
