sandynz commented on code in PR #21194:
URL: https://github.com/apache/shardingsphere/pull/21194#discussion_r980012956
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-api/src/main/java/org/apache/shardingsphere/data/pipeline/api/check/consistency/yaml/YamlDataConsistencyCheckResult.java:
##########
@@ -33,9 +33,9 @@
@Getter
@Setter
@ToString
-public final class YamlDataConsistencyCheckResultConfiguration {
+public final class YamlDataConsistencyCheckResult {
Review Comment:
`YamlDataConsistencyCheckResult` has different hierarchy with
`DataConsistencyCheckResult`, it's better to improve it
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-api/src/main/java/org/apache/shardingsphere/data/pipeline/api/job/progress/DataCheckJobItemProgress.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.data.pipeline.api.job.progress;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.shardingsphere.data.pipeline.api.job.JobStatus;
+
+/**
+ * Data check job item progress.
+ */
+@Getter
+@Setter
+public final class DataCheckJobItemProgress implements PipelineJobItemProgress
{
Review Comment:
`<YamlDataCheckJobProgress, DataCheckJobItemProgress>` looks strange, could
we rename `DataCheckJobItemProgress` to `ConsistencyCheckJobProgress`? And also
rename `YamlDataCheckJobProgress` to `YamlConsistencyCheckJobProgress`?
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/ConsistencyCheckJobAPIImpl.java:
##########
@@ -137,31 +163,23 @@ public PipelineTaskConfiguration
buildTaskConfiguration(final PipelineJobConfigu
return null;
}
- @Override
- protected String getTargetDatabaseType(final PipelineJobConfiguration
pipelineJobConfig) {
- return null;
- }
-
@Override
public InventoryIncrementalProcessContext
buildPipelineProcessContext(final PipelineJobConfiguration pipelineJobConfig) {
return null;
}
Review Comment:
`InventoryIncrementalProcessContext` could be `PipelineProcessContext`
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateConsistencyCheckJobParameter.java:
##########
@@ -30,4 +32,6 @@ public final class CreateConsistencyCheckJobParameter {
private final String jobId;
private final String algorithmTypeName;
+
+ private final Properties algorithmProperties;
Review Comment:
Could we rename `algorithmProperties` to `algorithmProps`, keep it
consistency as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
