[GitHub] [shardingsphere] sandynz commented on a diff in pull request #21508: Migration job stop cascade latest consistency check job

[GitBox]

sandynz commented on code in PR #21508:
URL: https://github.com/apache/shardingsphere/pull/21508#discussion_r992916069


##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobAPIImpl.java:
##########
@@ -266,7 +294,13 @@ private void dropCheckJobs(final String jobId) {
         log.info("dropCheckJobs start...");
         long startTimeMillis = System.currentTimeMillis();
         for (String each : checkJobIds) {
-            dropJob(each);
+            try {
+                dropJob(each);
+                // CHECKSTYLE:OFF
+            } catch (final RuntimeException ex) {
+                // CHECKSTYLE:ON
+                log.info("drop check job failed, check job id: {}, error: {}", 
each, ex.getMessage());

Review Comment:
   But it's used in logging, if `ignored` is used, it shows warning in IDEA:
   <img width="896" alt="图片" 
src="https://user-images.githubusercontent.com/42492540/195232159-80c929c8-d089-4726-bb12-3637c61ecfad.png";>
   The ignored case:
   <img width="413" alt="图片" 
src="https://user-images.githubusercontent.com/42492540/195232358-bf9f038e-d676-4d25-8a61-9f5f9e34f95e.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org