taojintianxia commented on code in PR #21585: URL: https://github.com/apache/shardingsphere/pull/21585#discussion_r996284332
########## jdbc/spring/core/shardingsphere-jdbc-core-spring-namespace/src/test/java/org/apache/shardingsphere/spring/namespace/fixture/FixtureClusterPersistRepository.java: ########## @@ -20,7 +20,6 @@ import org.apache.shardingsphere.infra.database.DefaultDatabase; import org.apache.shardingsphere.mode.repository.cluster.ClusterPersistRepository; import org.apache.shardingsphere.mode.repository.cluster.ClusterPersistRepositoryConfiguration; -import org.apache.shardingsphere.mode.repository.cluster.LeaderExecutionCallback; import org.apache.shardingsphere.mode.repository.cluster.listener.DataChangedEventListener; import java.util.Collections; Review Comment: hi @zhaojinchao95 there are some `return null` in your code. this is not the code of conduct we expected, please add TODO label or fix it directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
