sandynz commented on code in PR #21750:
URL: https://github.com/apache/shardingsphere/pull/21750#discussion_r1005180760
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/IncrementalTask.java:
##########
@@ -82,7 +82,7 @@ public IncrementalTask(final int concurrency, final
DumperConfiguration dumperCo
private IncrementalTaskProgress createIncrementalTaskProgress(final
IngestPosition<?> position, final InventoryIncrementalJobItemProgress
jobItemProgress) {
IncrementalTaskProgress incrementalTaskProgress = new
IncrementalTaskProgress();
incrementalTaskProgress.setPosition(position);
- if (null != jobItemProgress) {
+ if (null != jobItemProgress && null !=
jobItemProgress.getIncremental().getIncrementalTaskProgress()) {
incrementalTaskProgress.setIncrementalTaskDelay(jobItemProgress.getIncremental().getIncrementalTaskProgress().getIncrementalTaskDelay());
Review Comment:
`jobItemProgress.getIncremental()` might be null
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/ConsistencyCheckJob.java:
##########
@@ -74,12 +70,9 @@ public void stop() {
log.info("stop consistency check job, jobId is null, ignore");
return;
}
- for (PipelineTasksRunner each : getTasksRunnerMap().values()) {
+ for (PipelineTasksRunner each : getTaskRunners()) {
each.stop();
}
- getTasksRunnerMap().clear();
- String jobBarrierDisablePath =
PipelineMetaDataNode.getJobBarrierDisablePath(getJobId());
-
pipelineDistributedBarrier.persistEphemeralChildrenNode(jobBarrierDisablePath,
0);
-
PipelineJobProgressPersistService.removeJobProgressPersistContext(getJobId());
Review Comment:
`removeJobProgressPersistContext` is removed here, but not in migraiton job.
1, Is `removeJobProgressPersistContext` not needed for consistency job?
2, Could `removeJobProgressPersistContext` be added in AbstractPipelineJob?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
