I-Love-China commented on code in PR #21207:
URL: https://github.com/apache/shardingsphere/pull/21207#discussion_r1005254220
##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java:
##########
@@ -307,7 +307,9 @@ private ResultSet executeFederationQuery(final QueryContext
queryContext) throws
}
private DriverExecutionPrepareEngine<JDBCExecutionUnit, Connection>
createDriverExecutionPrepareEngine() {
- int maxConnectionsSizePerQuery =
metaDataContexts.getMetaData().getProps().<Integer>getValue(ConfigurationPropertyKey.MAX_CONNECTIONS_SIZE_PER_QUERY);
+ int maxConnectionsSizePerQuery = connection.isHoldTransaction()
Review Comment:
> The ShardingSphere local transaction manager does not guarantee
transaction correctness when routing to multiple data nodes. If required, use
XA transactions to guarantee transactional correctness across multiple data
nodes.
But these data nodes are located at the same database instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
