sandynz opened a new pull request, #21949:
URL: https://github.com/apache/shardingsphere/pull/21949

   
   Changes proposed in this pull request:
     - Remove shardingColumnsMap in SQL builder, so sharding column could be 
updated in `UPDATE tbl SET shardingColumn1=v ...` and upsert SQL (e.g. `INSERT 
INTO ... ON DUPLICATE KEY UPDATE ...`)
   
   TODO
   kernel doesn't support sharding column updating for now
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following 
options:
   - [ ] My code follows the [code of 
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) 
of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the 
pull request.
   - [ ] I have passed maven check locally : `mvn clean install -B -T2C 
-DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to