sandynz commented on code in PR #21929:
URL: https://github.com/apache/shardingsphere/pull/21929#discussion_r1013695156
##########
test/integration-test/scaling/src/test/resources/env/logback.xml:
##########
@@ -32,6 +32,7 @@
<appender-ref ref="console" />
</logger>
<logger name="com.zaxxer.hikari.pool.ProxyConnection" level="OFF" />
+ <logger name="org.apache.zookeeper.ZooKeeper" level="WARN"/>
<root>
<level value="WARN" />
<appender-ref ref="console" />
Review Comment:
The default level is `WARN`, could we use `ERROR` too at here
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/DataMatchDataConsistencyCalculateAlgorithm.java:
##########
@@ -224,7 +224,20 @@ public boolean equals(final Object o) {
}
return true;
}
-
+
+ private boolean checkDifferentNumberTypeMatched(final Number
thisResult, final Number thatResult) {
+ if (thisResult instanceof Integer) {
+ return thisResult.intValue() == thatResult.intValue();
+ }
+ if (thisResult instanceof Long) {
+ return thisResult.longValue() == thatResult.longValue();
+ }
+ if (thisResult instanceof Short) {
+ return thisResult.longValue() == thatResult.longValue();
+ }
Review Comment:
1, Why use `intValue` for Integer but `longValue` for other types
2, Does `Byte` need to do convert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
