taojintianxia commented on code in PR #22032: URL: https://github.com/apache/shardingsphere/pull/22032#discussion_r1017545818
########## test/integration-test/sql-parser/src/test/resources/env/it-env.properties: ########## @@ -17,3 +17,5 @@ sql.parser.it.enabled=false sql.parser.it.report.path=/tmp/ +# sql.parser.it.loader=github,gitee,local +sql.parser.it.loader=github Review Comment: as I know, in the following refactor process, you will apply the strategy pattern. but from this config file, I realized this may not be a strategy pattern . please think about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
