sandynz commented on code in PR #22048:
URL: https://github.com/apache/shardingsphere/pull/22048#discussion_r1019775307
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/ReflectionUtil.java:
##########
@@ -92,4 +92,33 @@ public static Object invokeMethod(final Object target, final
String methodName,
method.setAccessible(true);
return method.invoke(target, parameterValues);
}
+
+ /**
+ * invoke method in parent class.
Review Comment:
Java doc should start with uppercase character
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/ReflectionUtil.java:
##########
@@ -92,4 +92,33 @@ public static Object invokeMethod(final Object target, final
String methodName,
method.setAccessible(true);
return method.invoke(target, parameterValues);
}
+
+ /**
+ * invoke method in parent class.
+ *
+ * @param target target object
+ * @param methodName method name
+ * @param parameterTypes parameter types
+ * @param parameterValues parameter values
+ * @return invoke method result.
+ * @throws NoSuchMethodException no such field exception
+ * @throws InvocationTargetException invocation target exception
+ * @throws IllegalAccessException illegal access exception
+ */
+ public static Object invokeMethodInParentClass(final Object target, final
String methodName, final Class<?>[] parameterTypes,
+ final Object[]
parameterValues) throws NoSuchMethodException, InvocationTargetException,
IllegalAccessException {
Review Comment:
`invokeMethodInParentClass` is just used in unit test, could we put it to
test package?
Or else could we add unit test for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
