This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 87ad6249718 Refactor ShardingDistSQLStatementVisitor (#22295)
87ad6249718 is described below

commit 87ad6249718282ce0c566502adfa76d79ff6e365
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Nov 20 21:01:39 2022 +0800

    Refactor ShardingDistSQLStatementVisitor (#22295)
---
 .../distsql/parser/core/ShardingDistSQLStatementVisitor.java | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git 
a/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java
 
b/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java
index 436f9d37b22..b52e0f25644 100644
--- 
a/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java
+++ 
b/features/sharding/distsql/parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java
@@ -138,7 +138,7 @@ import java.util.Properties;
 import java.util.stream.Collectors;
 
 /**
- * SQL statement visitor for sharding dist SQL.
+ * Sharding DistSQL statement visitor.
  */
 public final class ShardingDistSQLStatementVisitor extends 
ShardingDistSQLStatementBaseVisitor<ASTNode> implements SQLVisitor {
     
@@ -232,14 +232,12 @@ public final class ShardingDistSQLStatementVisitor 
extends ShardingDistSQLStatem
     
     @Override
     public ASTNode visitAlterDefaultShardingStrategy(final 
AlterDefaultShardingStrategyContext ctx) {
-        ShardingStrategyContext shardingStrategyContext = 
ctx.shardingStrategy();
-        AlgorithmSegment algorithmSegment = null;
-        if (null != 
shardingStrategyContext.shardingAlgorithm().algorithmDefinition()) {
-            algorithmSegment = (AlgorithmSegment) 
visitAlgorithmDefinition(shardingStrategyContext.shardingAlgorithm().algorithmDefinition());
-        }
         String defaultType = new 
IdentifierValue(ctx.type.getText()).getValue();
-        String strategyType = 
getIdentifierValue(shardingStrategyContext.strategyType());
+        String strategyType = 
getIdentifierValue(ctx.shardingStrategy().strategyType());
         String shardingColumn = 
buildShardingColumn(ctx.shardingStrategy().shardingColumnDefinition());
+        AlgorithmSegment algorithmSegment = null == 
ctx.shardingStrategy().shardingAlgorithm().algorithmDefinition()
+                ? null
+                : (AlgorithmSegment) 
visitAlgorithmDefinition(ctx.shardingStrategy().shardingAlgorithm().algorithmDefinition());
         return new AlterDefaultShardingStrategyStatement(defaultType, 
strategyType, shardingColumn, algorithmSegment);
     }
     

Reply via email to