strongduanmu commented on code in PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#discussion_r1030075170
##########
features/sharding/api/src/main/java/org/apache/shardingsphere/sharding/api/sharding/complex/ComplexKeysShardingValue.java:
##########
@@ -39,4 +40,6 @@
private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
private final Map<String, Range<T>> columnNameAndRangeValuesMap;
+
+ private final DataNodeInfo dataNodeInfo;
Review Comment:
Currently, DataNodeInfo is extracted by regular expression, which is
suitable for auto table sharding algorithm, not user-defined sharding
algorithm. I worry that using DataNodeInfo in ComplexKeysShardingValue may
cause errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
