RaigorJiang commented on code in PR #22494:
URL: https://github.com/apache/shardingsphere/pull/22494#discussion_r1035706557
##########
features/encrypt/distsql/parser/src/main/antlr4/imports/encrypt/RDLStatement.g4:
##########
@@ -44,7 +44,7 @@ resourceName
;
encryptColumnDefinition
- : LP columnDefinition (COMMA plainColumnDefinition)? COMMA
cipherColumnDefinition (COMMA assistedQueryColumnDefinition)? (COMMA
likeQueryColumnDefinition)? COMMA algorithmDefinition (COMMA
algorithmDefinition)? (COMMA algorithmDefinition)? RP
+ : LP columnDefinition (COMMA plainColumnDefinition)? COMMA
cipherColumnDefinition (COMMA assistedQueryColumnDefinition)? (COMMA
likeQueryColumnDefinition)? COMMA cipherAlgorithm (COMMA assistedAlgorithm)?
(COMMA likeAlgorithm)? RP
Review Comment:
In order to be consistent with the definition of
[configuration](https://github.com/apache/shardingsphere/blob/master/features/encrypt/api/src/main/java/org/apache/shardingsphere/encrypt/api/config/rule/EncryptColumnRuleConfiguration.java),
I think it would be better if they were `encryptAlgorithm`,
`assistedQueryAlgorithm` and `likeQueryAlgorithm`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
