zhfeng commented on code in PR #22677:
URL: https://github.com/apache/shardingsphere/pull/22677#discussion_r1040412398
##########
jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/ShardingSphereDriverURL.java:
##########
@@ -72,4 +72,22 @@ public byte[] toConfigurationBytes() {
return builder.toString().getBytes(StandardCharsets.UTF_8);
}
}
+
+ private InputStream getResourceAsStream(final String resource) throws
IOException {
+ ClassLoader[] classLoaders = new ClassLoader[]{
+ Thread.currentThread().getContextClassLoader(),
getClass().getClassLoader(), ClassLoader.getSystemClassLoader(),
+ };
+ for (ClassLoader each : classLoaders) {
+ if (null != each) {
+ InputStream result = each.getResourceAsStream(resource);
+ if (null == result) {
+ result = each.getResourceAsStream("/" + resource);
+ }
Review Comment:
I added `,` in the arrays due to the checkstyle failures
```
[ERROR]
src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/ShardingSphereDriverURL.java:[79]
(coding) ArrayTrailingComma: 数组尾元素后应有逗号','。
```
So it need to change the `checkstyle.xml` to remove `<module
name="ArrayTrailingComma" />` ?
yeah, I run `mvn splotless:apply` and it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
