linghengqian commented on code in PR #22864:
URL: https://github.com/apache/shardingsphere/pull/22864#discussion_r1048273097
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/database/metadata/url/StandardJdbcUrlParser.java:
##########
@@ -31,7 +31,7 @@
*/
public final class StandardJdbcUrlParser {
- private static final String SCHEMA_PATTERN = "(?<schema>[\\w+:%]+)\\s*";
+ private static final String SCHEMA_PATTERN =
"(?<schema>[(\\w-.)+:%]+)\\s*";
Review Comment:
- For 1, and maybe it's just because I'm not familiar with regular
expressions, I can remove the extra parentheses.
- For 2, the current rule obviously doesn't, because I didn't escape the
characters, but I can't seem to relate what jdbcurl with parentheses looks
like. Any examples?🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
